From: Evgeniy Polyakov <zbr@ioremap.net>
To: Andreas Dilger <adilger@sun.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: Distributed storage release.
Date: Tue, 14 Oct 2008 20:12:56 +0400 [thread overview]
Message-ID: <20081014161256.GA22286@2ka.mipt.ru> (raw)
In-Reply-To: <20081014155143.GM2009@webber.adilger.int>
Hi Andreas.
On Tue, Oct 14, 2008 at 09:51:43AM -0600, Andreas Dilger (adilger@sun.com) wrote:
> While it is true that one coding style vs. another could be argued for
> a long time - the right answer is that the _right_ coding style for code
> added to the Linux kernel is Linus' CodingStyle document.
>
> Whether you think the braces here or there look better - consistency
> with other code in the same project is very important, and any changes
> you get to your code will come in the Linus CodingStyle and this will
> result in code that is a mix between your personal style and the official
> style and it will be a mess...
Like Scsi_Host and include/scsi/scsi_host.h? My favourite coding style
standards! It has the same space issues I have, but my code does not use
capital letters :)
I always wondered... I submit almost 5 thousands line of code and I'm
blamed that I do not have or have too many spaces in several dozens of
lines. Should I get it as kernel hackers can not say anything bad about
project except amount of spaces?
Btw, ext4 headers have the same issues with long lines as DST has. I'm
pretty sure no one would notice that (as long as in DST) without
checkpatch, which basically means that people do not care about the
code.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-10-14 16:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-06 16:00 Distributed storage release Evgeniy Polyakov
2008-10-13 2:24 ` Andrew Morton
2008-10-13 13:38 ` Evgeniy Polyakov
2008-10-13 13:44 ` Pekka Enberg
2008-10-13 14:14 ` Evgeniy Polyakov
2008-10-14 15:51 ` Andreas Dilger
2008-10-14 16:12 ` Evgeniy Polyakov [this message]
2008-10-14 20:35 ` Andreas Dilger
2008-10-14 21:08 ` Evgeniy Polyakov
2008-10-14 21:23 ` Matthew Wilcox
2008-10-14 21:31 ` Evgeniy Polyakov
-- strict thread matches above, loose matches on Subject: below --
2008-10-13 17:20 Evgeniy Polyakov
2008-10-14 23:23 ` Evgeniy Polyakov
2008-10-14 23:57 ` Evgeniy Polyakov
2008-09-09 11:38 Evgeniy Polyakov
2008-09-10 23:51 ` Sven Wegener
2008-09-11 4:23 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081014161256.GA22286@2ka.mipt.ru \
--to=zbr@ioremap.net \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).