public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/7] netns ebtables: part 1
Date: Thu, 16 Oct 2008 23:39:55 +0400	[thread overview]
Message-ID: <20081016193955.GA26245@x200.localdomain> (raw)
In-Reply-To: <48F73DA3.1030401@trash.net>

On Thu, Oct 16, 2008 at 03:12:03PM +0200, Patrick McHardy wrote:
> Alexey Dobriyan wrote:
>> One needs to add ".netns_ok = 1" to igmp_protocol to test all of this
>> with ebtables() in netns.
>> -------------------------------------------------
>> [PATCH 1/7] netns ebtables: part 1
>>
>> * make list of ebt_tables per-netns
>> * propagate netns from userspace, register table in passed netns
>> * temporarily register every ebt_table in init_net
>
> I'm not queuing patches for 2.6.29 yet, please resend the entire
> batch once Dave opens his net-next tree again.
>
>> --- a/include/net/netns/x_tables.h
>> +++ b/include/net/netns/x_tables.h
>> @@ -6,5 +6,6 @@
>>   struct netns_xt {
>>  	struct list_head tables[NPROTO];
>> +	struct list_head ebt_tables;
>
> This could just use tables[NFPROTO_BRIDGE].

Good!

[drops some code]

I do wonder why these new numbers a) contain holes and b) exported in
headers.

  reply	other threads:[~2008-10-16 19:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-15  4:20 [PATCH 1/7] netns ebtables: part 1 Alexey Dobriyan
2008-10-15  4:25 ` Alexey Dobriyan
2008-10-16 13:18   ` Patrick McHardy
2008-10-16 13:12 ` Patrick McHardy
2008-10-16 19:39   ` Alexey Dobriyan [this message]
2008-10-17 11:57     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081016193955.GA26245@x200.localdomain \
    --to=adobriyan@gmail.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox