From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: Josh Boyer <jwboyer@linux.vnet.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ibm_newemac: Fix new MAL feature handling
Date: Fri, 17 Oct 2008 14:56:52 +0200 [thread overview]
Message-ID: <200810171456.53599.arnd@arndb.de> (raw)
In-Reply-To: <20081016143840.GA29805@yoda.jdub.homelinux.org>
On Thursday 16 October 2008, Josh Boyer wrote:
> +#ifdef CONFIG_PPC_DCR_NATIVE
> if (mal_has_feature(mal, MAL_FTR_CLEAR_ICINTSTAT))
> mtdcri(SDR0, DCRN_SDR_ICINTSTAT,
> (mfdcri(SDR0, DCRN_SDR_ICINTSTAT) | ICINTSTAT_ICTX));
> +#endif
>
So what if you have a mmio based DRC implementation and still want to use
this feature?
I guess you really should use dcr_read/dcr_write here instead of mtdcr/mfdcr.
Arnd <><
next prev parent reply other threads:[~2008-10-17 12:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 4:33 powerpc allmodconfig Andrew Morton
2008-10-16 4:56 ` Benjamin Herrenschmidt
2008-10-16 14:38 ` [PATCH] ibm_newemac: Fix new MAL feature handling Josh Boyer
2008-10-17 12:56 ` Arnd Bergmann [this message]
2008-10-17 13:09 ` Josh Boyer
2008-10-20 23:43 ` Benjamin Herrenschmidt
2008-10-21 5:17 ` Jeff Garzik
2008-10-16 5:02 ` powerpc allmodconfig David Miller
2008-10-16 6:08 ` Dan Williams
2008-10-16 6:55 ` Brice Goglin
2008-10-16 6:58 ` David Miller
2008-10-16 16:22 ` Jesse Brandeburg
2008-10-16 7:31 ` Geert Uytterhoeven
2008-10-16 7:36 ` David Miller
2008-10-16 7:58 ` Geert Uytterhoeven
2008-10-16 7:53 ` Andreas Schwab
[not found] ` <20081015.220247.262683261.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-10-16 5:21 ` Benjamin Herrenschmidt
2008-10-16 14:57 ` Johannes Berg
[not found] ` <1224169039.735.57.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2008-10-16 19:49 ` David Miller
2008-10-16 20:02 ` Arjan van de Ven
2008-10-18 12:20 ` Johannes Berg
2008-10-17 11:09 ` Ingo Molnar
2008-10-16 5:57 ` Takashi Iwai
2008-10-16 7:38 ` Adrian Bunk
2008-10-16 7:57 ` Takashi Iwai
2008-10-16 8:21 ` Adrian Bunk
[not found] ` <20081016082157.GC23630-re2QNgSbS3j4D6uPqz5PAwR5/fbUUdgG@public.gmane.org>
2008-10-16 8:43 ` Takashi Iwai
[not found] ` <s5hod1lorpm.wl%tiwai-l3A5Bk7waGM@public.gmane.org>
2008-10-16 10:03 ` Adrian Bunk
2008-10-16 9:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810171456.53599.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).