From: Thomas Graf <tgraf@suug.ch>
To: Andi Kleen <andi@firstfloor.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] pkt_sched: Control group classifier
Date: Fri, 17 Oct 2008 20:23:12 +0200 [thread overview]
Message-ID: <20081017182312.GE20815@postel.suug.ch> (raw)
In-Reply-To: <873aixksf0.fsf@basil.nowhere.org>
* Andi Kleen <andi@firstfloor.org> 2008-10-16 07:41
> Thomas Graf <tgraf@suug.ch> writes:
> >
> > The principle of the classifier is to directly access the
> > task_struct via get_current(). In order for this to work,
> > classification requests from softirqs must be ignored.
>
> You mean the classifier just wants to know if it runs
> as a softirq?
Yes, exactly.
> > This is
> > not a problem because the vast majority of packets in softirq
> > context are not assigned to a task anyway. For this to work, a
> > mechanism is needed to trace softirq context.
> > The only existing
> > way to do so is to use the TRACE_IRQFLAGS feature, unfortunately
>
> Does't softirq_count() > 0 check that?
softirq_count() simply counts the levels of bh disable.
next prev parent reply other threads:[~2008-10-17 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 15:57 [PATCH] pkt_sched: Control group classifier Thomas Graf
2008-10-14 11:56 ` Chei-yol Kim
2008-10-14 17:00 ` Thomas Graf
2008-10-14 17:03 ` Thomas Graf
2008-10-16 5:41 ` Andi Kleen
2008-10-17 18:23 ` Thomas Graf [this message]
2008-10-17 18:32 ` Andi Kleen
2008-10-17 20:09 ` Thomas Graf
2008-10-18 5:38 ` Andi Kleen
2008-10-19 17:00 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081017182312.GE20815@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).