* [PATCH] netdev: change name dropping error codes
@ 2008-10-18 4:30 Stephen Hemminger
2008-10-20 6:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2008-10-18 4:30 UTC (permalink / raw)
To: David Miller; +Cc: netdev
If changename notifier returns an error code, it gets incorrectly
cleared during rollback so the error is never returned to the user.
Found while testing similar code for MTU changes.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/core/dev.c 2008-10-17 18:59:11.000000000 -0700
+++ b/net/core/dev.c 2008-10-17 21:22:30.000000000 -0700
@@ -924,10 +924,10 @@ int dev_change_name(struct net_device *d
strlcpy(dev->name, newname, IFNAMSIZ);
rollback:
- err = device_rename(&dev->dev, dev->name);
- if (err) {
+ ret = device_rename(&dev->dev, dev->name);
+ if (ret) {
memcpy(dev->name, oldname, IFNAMSIZ);
- return err;
+ return ret;
}
write_lock_bh(&dev_base_lock);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] netdev: change name dropping error codes
2008-10-18 4:30 [PATCH] netdev: change name dropping error codes Stephen Hemminger
@ 2008-10-20 6:34 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-10-20 6:34 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 17 Oct 2008 21:30:06 -0700
> If changename notifier returns an error code, it gets incorrectly
> cleared during rollback so the error is never returned to the user.
> Found while testing similar code for MTU changes.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-20 6:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-18 4:30 [PATCH] netdev: change name dropping error codes Stephen Hemminger
2008-10-20 6:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).