From: David Miller <davem@davemloft.net>
To: acme@redhat.com
Cc: hidden@sch.bme.hu, gerrit@erg.abdn.ac.uk, netdev@vger.kernel.org
Subject: Re: 2.6.27 [BUG-FIX] [PATCH 1/1] dccp: Port redirection support for DCCP
Date: Sun, 19 Oct 2008 23:37:03 -0700 (PDT) [thread overview]
Message-ID: <20081019.233703.12321683.davem@davemloft.net> (raw)
In-Reply-To: <20081018152502.GJ19353@ghostprotocols.net>
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Sat, 18 Oct 2008 12:25:02 -0300
> Em Sat, Oct 18, 2008 at 12:21:58PM +0200, KOVACS Krisztian escreveu:
> > dccp: Port redirection support for DCCP
> >
> > Commit a3116ac5c216fc3c145906a46df9ce542ff7dcf2 from 1st October ("tcp: Port
> > redirection support for TCP") broke DCCP skb lookup by changing inet_csk_clone,
> > which is used by DCCP to generate the child socket after the handshake.
> >
> > This patch updates DCCP to use 'loc_port' instead of 'sport', which fixes the
> > problem, and thus inheriting port redirection support via the new interface.
> >
> > Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
> > Signed-off-by: KOVACS Krisztian <hidden@sch.bme.hu>
>
> Good work! Better two fixes than none! :-)
>
> Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Applied, thanks everyone.
prev parent reply other threads:[~2008-10-20 6:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-18 9:21 2.6.27 [BUG-FIX] [PATCH 1/1] dccp: Port redirection support for DCCP Gerrit Renker
2008-10-18 9:48 ` KOVACS Krisztian
2008-10-18 10:06 ` 2.6.27 [BUG-FIX] [PATCH 1/1] dccp: Port redirection support for?DCCP Gerrit Renker
2008-10-18 10:21 ` 2.6.27 [BUG-FIX] [PATCH 1/1] dccp: Port redirection support for DCCP KOVACS Krisztian
2008-10-18 15:25 ` Arnaldo Carvalho de Melo
2008-10-20 6:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081019.233703.12321683.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@redhat.com \
--cc=gerrit@erg.abdn.ac.uk \
--cc=hidden@sch.bme.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).