From: Stephen Hemminger <shemminger@vyatta.com>
To: jeffery.t.kirsher@intel.com, jesse.brandeburg@intel.com,
bruce.w.allan@intel.com, peter.p.waskiewicz.jr@intel.com
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: [RFC 1/2] igb: statistic optimization
Date: Tue, 21 Oct 2008 12:09:35 -0700 [thread overview]
Message-ID: <20081021120935.1b3cea8d@extreme> (raw)
The network statistics were being updated by multiple CPU's causing cache
line bounces. Since this driver already keeps statistics per ring, use
those to compute the bytes/packet statistics.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
Compile tested only, evaluation in progress
--- a/drivers/net/igb/igb_main.c 2008-10-21 08:57:11.000000000 -0700
+++ b/drivers/net/igb/igb_main.c 2008-10-21 09:05:43.000000000 -0700
@@ -3029,9 +3029,27 @@ static struct net_device_stats *
igb_get_stats(struct net_device *netdev)
{
struct igb_adapter *adapter = netdev_priv(netdev);
+ struct net_device_stats *stats = &adapter->net_stats;
+ int i;
+
+ stats->tx_bytes = 0;
+ stats->tx_packets = 0;
+ for (i = 0; i < adapter->num_tx_queues; i++) {
+ struct igb_ring *tx_ring = &adapter->tx_ring[i];
+ stats->tx_bytes += tx_ring->tx_stats.bytes;
+ stats->tx_packets += tx_ring->tx_stats.packets;
+ }
+ stats->rx_bytes = 0;
+ stats->rx_packets = 0;
+ for (i = 0; i < adapter->num_rx_queues; i++) {
+ struct igb_ring *rx_ring = &adapter->rx_ring[i];
+ stats->rx_bytes += rx_ring->rx_stats.bytes;
+ stats->rx_packets += rx_ring->rx_stats.packets;
+ }
+
+ igb_update_stats(adapter);
- /* only return the current stats */
- return &adapter->net_stats;
+ return stats;
}
/**
@@ -3711,8 +3729,6 @@ done_cleaning:
tx_ring->total_packets += total_packets;
tx_ring->tx_stats.bytes += total_bytes;
tx_ring->tx_stats.packets += total_packets;
- adapter->net_stats.tx_bytes += total_bytes;
- adapter->net_stats.tx_packets += total_packets;
return retval;
}
@@ -3953,8 +3969,6 @@ next_desc:
rx_ring->total_bytes += total_bytes;
rx_ring->rx_stats.packets += total_packets;
rx_ring->rx_stats.bytes += total_bytes;
- adapter->net_stats.rx_bytes += total_bytes;
- adapter->net_stats.rx_packets += total_packets;
return cleaned;
}
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
next reply other threads:[~2008-10-21 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 19:09 Stephen Hemminger [this message]
2008-10-21 19:30 ` [RFC 1/2] igb: statistic optimization Brandeburg, Jesse
2008-10-21 19:31 ` Waskiewicz Jr, Peter P
2008-10-22 17:37 ` Rick Jones
2008-10-22 17:54 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021120935.1b3cea8d@extreme \
--to=shemminger@vyatta.com \
--cc=bruce.w.allan@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffery.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).