From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Steve.Glendinning@smsc.com
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Bill Gatliff <bgat@billgatliff.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-arm-kernel@lists.arm.linux.org.uk, Ian.Saturley@smsc.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 14/16] RealView: Use the in-kernel smc911x.c driver on RealView
Date: Tue, 21 Oct 2008 19:46:53 +0100 [thread overview]
Message-ID: <20081021184653.GA15027@flint.arm.linux.org.uk> (raw)
In-Reply-To: <OF6B543A5F.032D7BBC-ON802574E9.00340E58-802574E9.00396C6E@smsc.com>
On Tue, Oct 21, 2008 at 11:26:42AM +0100, Steve.Glendinning@smsc.com wrote:
> Almost all the feedback I've had has been positive, but I've had a few
> "can't you just fix the in-tree driver?" responses. The trouble is it's
> not a *small* piece of work!
Which is reasonable given your summary, since...
> smsc911x
> - uses functions instead of macros, making it more readable
> - uses napi (and manages significantly higher throughput because of it)
> - uses phylib
> - passes checkpatch.pl
> - has workarounds for older LAN911x variants
>
> smc911x
> - is already in-tree (not really technical, but still important)
> - has support for pxa dma*
> - has dynamic bus width config
.. we want to avoid having two drivers for the same device, but not
supporting these features would be seen as a regression.
next prev parent reply other threads:[~2008-10-21 18:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1224578293.9330.9.camel@pc1117.cambridge.arm.com>
2008-10-21 10:26 ` [PATCH 14/16] RealView: Use the in-kernel smc911x.c driver on RealView Steve.Glendinning
2008-10-21 10:42 ` Catalin Marinas
2008-10-21 13:25 ` Bill Gatliff
2008-10-21 18:48 ` Russell King - ARM Linux
2008-10-21 13:27 ` Bill Gatliff
2008-10-21 18:46 ` Russell King - ARM Linux [this message]
2008-10-21 19:32 ` Steve.Glendinning
2008-11-04 16:12 Steve.Glendinning
2008-11-04 20:25 ` Bill Gatliff
2008-11-04 22:16 ` Steve.Glendinning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021184653.GA15027@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Ian.Saturley@smsc.com \
--cc=Steve.Glendinning@smsc.com \
--cc=bgat@billgatliff.com \
--cc=catalin.marinas@arm.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).