Current git r8169 driver often misses link at boot

Current git r8169 driver often misses link at boot

[Andi Kleen]

Hi,

I have a nfsroot test system with a r8169 NIC. Since I updated
from 2.6.27 to 2.6.27-git10 it doesn't find its root fs in 2 out of
3 boots. The r8169 gets detected, but there is never
a message that it finds the link in the failed cases:

r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
r8169 0000:02:00.0: PCI INT A -> GSI 18 (level, low) -> IRQ 18
r8169 0000:02:00.0: setting latency timer to 64
r8169 0000:02:00.0: irq 45 for MSI/MSI-X
eth0: RTL8168b/8111b at 0xffffc2000035a000, 00:00:00:00:00:00, XID 38000000 IRQ 
45

I tried to revert back to the 2.6.27 r8169.c and that fixed
the problem here. Didn't see a hang so far in 4 boots with
the old driver.

I also originally thought it was related to netconsole, but even
with that removed the problem still happens.

-Andi

-- 
ak@linux.intel.com

Re: Current git r8169 driver often misses link at boot

[Francois Romieu]

Andi Kleen <andi@firstfloor.org> :
[...]
> I have a nfsroot test system with a r8169 NIC. Since I updated
> from 2.6.27 to 2.6.27-git10 it doesn't find its root fs in 2 out of
> 3 boots. The r8169 gets detected, but there is never
> a message that it finds the link in the failed cases:
> 
> r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
> r8169 0000:02:00.0: PCI INT A -> GSI 18 (level, low) -> IRQ 18
> r8169 0000:02:00.0: setting latency timer to 64
> r8169 0000:02:00.0: irq 45 for MSI/MSI-X
> eth0: RTL8168b/8111b at 0xffffc2000035a000, 00:00:00:00:00:00, XID 38000000 IRQ 45

The workarounds are in Jeff's tree as :
9b1abbccf53ef1a1213b159d56257b535c599f07
d7d25be4418b609e54b407458003a4b6bff1c63b

-- 
Ueimor

Re: Current git r8169 driver often misses link at boot

[David Miller]

From: Andi Kleen <andi@firstfloor.org>
Date: Wed, 22 Oct 2008 01:50:11 +0200

> On Tue, Oct 21, 2008 at 10:26:01PM +0200, Francois Romieu wrote:
> > Andi Kleen <andi@firstfloor.org> :
> > [...]
> > > I have a nfsroot test system with a r8169 NIC. Since I updated
> > > from 2.6.27 to 2.6.27-git10 it doesn't find its root fs in 2 out of
> > > 3 boots. The r8169 gets detected, but there is never
> > > a message that it finds the link in the failed cases:
> > > 
> > > r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
> > > r8169 0000:02:00.0: PCI INT A -> GSI 18 (level, low) -> IRQ 18
> > > r8169 0000:02:00.0: setting latency timer to 64
> > > r8169 0000:02:00.0: irq 45 for MSI/MSI-X
> > > eth0: RTL8168b/8111b at 0xffffc2000035a000, 00:00:00:00:00:00, XID 38000000 IRQ 45
> > 
> > The workarounds are in Jeff's tree as :
> > 9b1abbccf53ef1a1213b159d56257b535c599f07
> > d7d25be4418b609e54b407458003a4b6bff1c63b
> 
> Confirmed.
> 
> With upstream-fixes it survived three boots now. Can this fix please
> be submitted ASAP, not having it impacts testing here.

I can't, as Jeff's pull request breaks the build.

He'll hopefully fix that up and resubmit to me soon, sit tight.

Re: Current git r8169 driver often misses link at boot

[Andi Kleen]

On Tue, Oct 21, 2008 at 10:26:01PM +0200, Francois Romieu wrote:
> Andi Kleen <andi@firstfloor.org> :
> [...]
> > I have a nfsroot test system with a r8169 NIC. Since I updated
> > from 2.6.27 to 2.6.27-git10 it doesn't find its root fs in 2 out of
> > 3 boots. The r8169 gets detected, but there is never
> > a message that it finds the link in the failed cases:
> > 
> > r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
> > r8169 0000:02:00.0: PCI INT A -> GSI 18 (level, low) -> IRQ 18
> > r8169 0000:02:00.0: setting latency timer to 64
> > r8169 0000:02:00.0: irq 45 for MSI/MSI-X
> > eth0: RTL8168b/8111b at 0xffffc2000035a000, 00:00:00:00:00:00, XID 38000000 IRQ 45
> 
> The workarounds are in Jeff's tree as :
> 9b1abbccf53ef1a1213b159d56257b535c599f07
> d7d25be4418b609e54b407458003a4b6bff1c63b

Confirmed.

With upstream-fixes it survived three boots now. Can this fix please
be submitted ASAP, not having it impacts testing here.

Thanks,
-Andi