From: Stephen Hemminger <shemminger@vyatta.com>
To: Rick Jones <rick.jones2@hp.com>
Cc: "e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"jeffery.t.kirsher@intel.com" <jeffery.t.kirsher@intel.com>
Subject: Re: [RFC 1/2] igb: statistic optimization
Date: Wed, 22 Oct 2008 10:54:58 -0700 [thread overview]
Message-ID: <20081022105458.59814157@extreme> (raw)
In-Reply-To: <48FF64E8.4050907@hp.com>
On Wed, 22 Oct 2008 10:37:44 -0700
Rick Jones <rick.jones2@hp.com> wrote:
> > I don't think you want to put this in the code that can be called directly
> > from IOCTL from userspace. This function can take a lot of cycles and
> > some silly applications like gkrellm call it quite frequently. The
> > update_stats function will be called as part of the watchdog anyway, and
> > you already got the interesting stats for realtime with the tx and rx
> > bytes/packets.
>
> On the flip side aren't there "out of phase" issues with pulling stats
> based on a timer vs something like a netstat -i 1 command?
>
> rick jones
The only stats pulled are the error stats, so this is probably okay.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
prev parent reply other threads:[~2008-10-22 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 19:09 [RFC 1/2] igb: statistic optimization Stephen Hemminger
2008-10-21 19:30 ` Brandeburg, Jesse
2008-10-21 19:31 ` Waskiewicz Jr, Peter P
2008-10-22 17:37 ` Rick Jones
2008-10-22 17:54 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022105458.59814157@extreme \
--to=shemminger@vyatta.com \
--cc=bruce.w.allan@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffery.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=rick.jones2@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).