From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [RFC 1/2] igb: statistic optimization Date: Wed, 22 Oct 2008 10:54:58 -0700 Message-ID: <20081022105458.59814157@extreme> References: <20081021120935.1b3cea8d@extreme> <48FF64E8.4050907@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "e1000-devel@lists.sourceforge.net" , "netdev@vger.kernel.org" , "Waskiewicz Jr, Peter P" , "Allan, Bruce W" , "Brandeburg, Jesse" , "jeffery.t.kirsher@intel.com" To: Rick Jones Return-path: In-Reply-To: <48FF64E8.4050907@hp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org On Wed, 22 Oct 2008 10:37:44 -0700 Rick Jones wrote: > > I don't think you want to put this in the code that can be called directly > > from IOCTL from userspace. This function can take a lot of cycles and > > some silly applications like gkrellm call it quite frequently. The > > update_stats function will be called as part of the watchdog anyway, and > > you already got the interesting stats for realtime with the tx and rx > > bytes/packets. > > On the flip side aren't there "out of phase" issues with pulling stats > based on a timer vs something like a netstat -i 1 command? > > rick jones The only stats pulled are the error stats, so this is probably okay. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/