From: "Matt Carlson" <mcarlson@broadcom.com>
To: "Herbert Xu" <herbert@gondor.apana.org.au>
Cc: "David Miller" <davem@davemloft.net>,
"berni@birkenwald.de" <berni@birkenwald.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Matthew Carlson" <mcarlson@broadcom.com>
Subject: Re: WARNING (skb_gso_segment) with tg3+bridge in 2.6.27
Date: Wed, 22 Oct 2008 10:57:04 -0700 [thread overview]
Message-ID: <20081022175704.GA25286@xw6200.broadcom.net> (raw)
In-Reply-To: <20081022074502.GA25058@gondor.apana.org.au>
On Wed, Oct 22, 2008 at 12:45:02AM -0700, Herbert Xu wrote:
> On Mon, Oct 13, 2008 at 12:42:26AM -0700, David Miller wrote:
> > From: Bernhard Schmidt <berni@birkenwald.de>
> > Date: Sat, 11 Oct 2008 19:20:03 +0200
> >
> > > [ 289.588669] ------------[ cut here ]------------
> > > [ 289.588673] WARNING: at net/core/dev.c:1505 skb_gso_segment+0x82/0x1a7()
> > >
> > > if (WARN_ON(skb->ip_summed != CHECKSUM_PARTIAL)) {
> >
> > So this is via tg3_tso_bug()
> >
> > ...
> > > [ 289.588760] [<ffffffff803d14ab>] dev_queue_xmit+0x3aa/0x462
> > > [ 289.588778] [<ffffffffa024ca8c>] ip6_output+0xce7/0xcff [ipv6]
> > > [ 289.588785] [<ffffffffa023ade0>] br_dev_queue_push_xmit+0x75/0x79 [bridge]
> > > [ 289.588792] [<ffffffffa023a2fe>] br_dev_xmit+0x66/0x7c [bridge]
> > > [ 289.588795] [<ffffffff803d1535>] dev_queue_xmit+0x434/0x462
> > > [ 289.588811] [<ffffffffa024ca8c>] ip6_output+0xce7/0xcff [ipv6]
> > > [ 289.588827] [<ffffffffa024b8b4>] ip6_xmit+0x35c/0x439 [ipv6]
> > > [ 289.588848] [<ffffffffa026d303>] inet6_csk_xmit+0x223/0x236 [ipv6]
> > > [ 289.588850] [<ffffffff80443e8e>] _spin_lock_irqsave+0x21/0x29
> > > [ 289.588853] [<ffffffff804059ff>] tcp_transmit_skb+0x60f/0x64e
> >
> > And it seems we have a TCP TSO frame that went through bridging
> > netfilter.
>
> I'm pretty sure this particular backtrace is a result of tg3
> enabling NETIF_F_TSO6 without also enabling NETIF_F_IPV6_CSUM.
Looking at the dmesg output, I see that the tg3 device is a 5714.
NETIF_F_TSO6 should not be enabled for the 5714. Why is the driver
getting an IPv6 TSO packet?
> So my question is to the tg3 developers, does having TSO6 without
> IPv6 checksums ever make sense?
No. TSO implies checksum offload.
> Put it another way, how can you
> have a device that can compute checksums for TCPv6 packets but
> not UDPv6 packets?
The checksum operations should be exactly the same between the two.
I can't help but wonder why UDP entered the scene though. The tg3
driver never sets NETIF_F_UFO.
> Thanks,
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>
next prev parent reply other threads:[~2008-10-22 17:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-11 17:20 WARNING (skb_gso_segment) with tg3+bridge in 2.6.27 Bernhard Schmidt
2008-10-13 7:42 ` David Miller
2008-10-13 7:59 ` Herbert Xu
2008-10-22 7:45 ` Herbert Xu
2008-10-22 17:57 ` Matt Carlson [this message]
2008-10-23 2:20 ` Herbert Xu
2008-10-23 17:13 ` Michael Chan
2008-10-24 14:33 ` Herbert Xu
2009-05-07 21:23 ` Ferenc Wágner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022175704.GA25286@xw6200.broadcom.net \
--to=mcarlson@broadcom.com \
--cc=berni@birkenwald.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).