From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, yjwei@cn.fujitsu.com
Subject: Re: [PATCH 3/4] sctp: Fix to handle SHUTDOWN in SHUTDOWN-PENDING state
Date: Thu, 23 Oct 2008 01:00:58 -0700 (PDT) [thread overview]
Message-ID: <20081023.010058.31323273.davem@davemloft.net> (raw)
In-Reply-To: <1224641327-11913-4-git-send-email-vladislav.yasevich@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Tue, 21 Oct 2008 22:08:46 -0400
> If SHUTDOWN is received in SHUTDOWN-PENDING state, enpoint should enter
> the SHUTDOWN-RECEIVED state and check the Cumulative TSN Ack field of
> the SHUTDOWN chunk (RFC 4960 Section 9.2). If the SHUTDOWN chunk can
> acknowledge all of the send DATA chunks, SHUTDOWN-ACK should be sent.
>
> But now endpoint just silently discarded the SHUTDOWN chunk.
>
> SHUTDOWN received in SHUTDOWN-PENDING state can happend when the last
> SACK is lost by network, or the SHUTDOWN chunk can acknowledge all of
> the received DATA chunks. The packet sequence(SACK lost) is like this:
>
> Endpoint A Endpoint B ULP
> (ESTABLISHED) (ESTABLISHED)
>
> <----------- DATA
> <--- shutdown
> Enter SHUTDOWN-PENDING state
> SACK ----lost---->
>
> SHUTDOWN(*1) ------------>
>
> <----------- SHUTDOWN-ACK
>
> (*1) silently discarded now.
>
> This patch fix to handle SHUTDOWN in SHUTDOWN-PENDING state as the same
> as ESTABLISHED state.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Applied.
next prev parent reply other threads:[~2008-10-23 8:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 2:08 [PATCH] sctp: rfc conformance fixes Vlad Yasevich
2008-10-22 2:08 ` [PATCH 1/4] sctp: Drop ICMP packet too big message with MTU larger than current PMTU Vlad Yasevich
2008-10-23 8:00 ` David Miller
2008-10-22 2:08 ` [PATCH 2/4] sctp: Add check for the TSN field of the SHUTDOWN chunk Vlad Yasevich
2008-10-23 8:00 ` David Miller
2008-10-22 2:08 ` [PATCH 3/4] sctp: Fix to handle SHUTDOWN in SHUTDOWN-PENDING state Vlad Yasevich
2008-10-23 8:00 ` David Miller [this message]
2008-10-22 2:08 ` [PATCH 4/4] sctp: Fix to handle SHUTDOWN in SHUTDOWN_RECEIVED state Vlad Yasevich
2008-10-23 8:01 ` David Miller
2008-10-22 4:05 ` [PATCH] sctp: rfc conformance fixes David Miller
2008-10-22 4:44 ` Maxime Bizon
2008-10-22 4:47 ` David Miller
2008-10-22 5:01 ` Jeremy Kerr
2008-10-22 5:32 ` Maxime Bizon
2008-10-22 5:35 ` Jeremy Kerr
2008-10-22 6:02 ` Maxime Bizon
2008-10-22 13:03 ` Vlad Yasevich
2008-10-22 22:54 ` Jeremy Kerr
2008-10-22 23:46 ` David Miller
2008-10-22 23:48 ` David Miller
2008-10-23 1:24 ` Vlad Yasevich
2008-10-23 4:06 ` David Miller
2008-10-23 6:15 ` Simon Horman
2008-10-23 8:06 ` David Miller
[not found] ` <48FFBA06.50609@hp.com>
2008-10-23 0:43 ` Jeremy Kerr
2008-10-23 3:34 ` Jeremy Kerr
2008-10-23 4:11 ` David Miller
2008-10-23 5:47 ` Benjamin Herrenschmidt
2008-10-23 5:54 ` Jeremy Kerr
2008-10-22 6:12 ` David Miller
2008-10-22 16:48 ` Maxime Bizon
2008-10-22 21:10 ` David Miller
2008-10-22 23:42 ` Vlad Yasevich
2008-10-23 4:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023.010058.31323273.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladislav.yasevich@hp.com \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).