From: Evgeniy Polyakov <zbr@ioremap.net>
To: David Miller <davem@davemloft.net>
Cc: michellammertink@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] netlink: fix append of whole original message on negative ack.
Date: Fri, 24 Oct 2008 00:55:43 +0400 [thread overview]
Message-ID: <20081023205543.GA19462@ioremap.net> (raw)
In-Reply-To: <20081023.134513.267548182.davem@davemloft.net>
Hi.
On Thu, Oct 23, 2008 at 01:45:13PM -0700, David Miller (davem@davemloft.net) wrote:
> > Netlink can return an negative acknowledgement, which AFAICT should include an error code and the whole original message. This patch fixes the size argument given to the __nlmsg_put call. Without this patch only the original header was attached.
> > ---
> >
> > Can anyone explain to me why struct nlmsgerr contains an int error and the nlmsghdr struct. The comment in netlink_ack states that the whole message should be appended. Why not only include an int error in struct nlmsgerr and just append the original message?
Having header (even seq/pid only) is enough to find a message
for that userspace which cares. Looks like your patch can break
existing applications which are used to work with header only,
even if that was a mistake? Although application is supposed to
check the length, it still can expect only a header. I have to
note, that I do not know any such application though.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-10-23 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4900BFCF.2030707@gmail.com>
2008-10-23 20:45 ` [PATCH] netlink: fix append of whole original message on negative ack David Miller
2008-10-23 20:55 ` Evgeniy Polyakov [this message]
2008-10-23 21:02 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023205543.GA19462@ioremap.net \
--to=zbr@ioremap.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michellammertink@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).