* [PATCH] virtio_net: hook up the set-tso ethtool op
@ 2008-10-22 15:32 Mark McLoughlin
2008-10-23 15:33 ` Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Mark McLoughlin @ 2008-10-22 15:32 UTC (permalink / raw)
To: Rusty Russell; +Cc: netdev, virtualization
Seems like an oversight that we have set-tx-csum and set-sg hooked
up, but not set-tso.
Also leads to the strange situation that if you e.g. disable tx-csum,
then tso doesn't get disabled.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
---
drivers/net/virtio_net.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index cca6435..79b59cc 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -612,6 +612,7 @@ static int virtnet_set_tx_csum(struct net_device *dev, u32 data)
static struct ethtool_ops virtnet_ethtool_ops = {
.set_tx_csum = virtnet_set_tx_csum,
.set_sg = ethtool_op_set_sg,
+ .set_tso = ethtool_op_set_tso,
};
static int virtnet_probe(struct virtio_device *vdev)
--
1.6.0.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] virtio_net: hook up the set-tso ethtool op
2008-10-22 15:32 [PATCH] virtio_net: hook up the set-tso ethtool op Mark McLoughlin
@ 2008-10-23 15:33 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2008-10-23 15:33 UTC (permalink / raw)
To: Mark McLoughlin; +Cc: netdev, virtualization
On Thursday 23 October 2008 02:32:26 Mark McLoughlin wrote:
> Seems like an oversight that we have set-tx-csum and set-sg hooked
> up, but not set-tso.
>
> Also leads to the strange situation that if you e.g. disable tx-csum,
> then tso doesn't get disabled.
Thanks, applied.
Rusty.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-23 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-22 15:32 [PATCH] virtio_net: hook up the set-tso ethtool op Mark McLoughlin
2008-10-23 15:33 ` Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).