From: Stephen Hemminger <shemminger@vyatta.com>
To: Brice Goglin <brice@myri.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] per-nic module parameters
Date: Fri, 24 Oct 2008 13:39:20 -0700 [thread overview]
Message-ID: <20081024133920.6588026c@extreme> (raw)
In-Reply-To: <49022B7F.8080809@myri.com>
On Fri, 24 Oct 2008 22:09:35 +0200
Brice Goglin <brice@myri.com> wrote:
> Hello,
>
> We're working on making myri10ge module parameters per-nic. It looks
> like ixgb already does so with the following macro in ixgb_param.c:
>
> #define IXGB_PARAM_INIT { [0 ... IXGB_MAX_NIC] = OPTION_UNSET }
> #define IXGB_PARAM(X, desc) \
> static int __devinitdata X[IXGB_MAX_NIC+1] \
> = IXGB_PARAM_INIT; \
> static unsigned int num_##X = 0; \
> module_param_array_named(X, X, int, &num_##X, 0); \
> MODULE_PARM_DESC(X, desc);
>
> Is this the recommended way to implement per-nic module params? Or
> should we do something else?
Module parameters are bad. They are device specific and awkward for
any general configuration system to deal with. As much as possible,
please convert any module parameters to real interfaces like netlink,
ethtool, or sysfs.
next prev parent reply other threads:[~2008-10-24 20:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 20:09 [RFC] per-nic module parameters Brice Goglin
2008-10-24 20:39 ` Stephen Hemminger [this message]
2008-10-24 21:01 ` Ben Hutchings
2008-10-25 11:06 ` Chris Snook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024133920.6588026c@extreme \
--to=shemminger@vyatta.com \
--cc=brice@myri.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).