From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "Benjamin Li" <benli@broadcom.com>,
netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: PCI VPD size
Date: Fri, 24 Oct 2008 14:18:38 -0700 [thread overview]
Message-ID: <200810241418.38733.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <20081024125035.4ebad408@extreme>
On Friday, October 24, 2008 12:50 pm Stephen Hemminger wrote:
> Why did you choose to limit VPD access by using PCI quirks:
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h
>=99cb233d60cbe644203f19938c729ea2bb004d70
>
> Rather than controlling size in the device driver which is what my
> patches (which seem to have been ignored) did:
> http://marc.info/?l=linux-netdev&m=122393195716363&w=2
>
> The problem with the quirk scheme is that it means putting more
> per device settings in a location farther away in the source code
> than the underlying device driver.
The last status I received on that was a comment from Jeff about assuming the
maximum size for the VPD space. That's the whole reason we have the quirks:
on many devices accessing beyond the end of VPD space can cause a device hang.
And since that space is available from a sysfs file we need to be extra
careful.
Other than that, your patches looked fine, I was just waiting for you to
address that last comment.
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2008-10-24 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 19:50 PCI VPD size Stephen Hemminger
2008-10-24 20:52 ` Ben Hutchings
2008-10-24 21:18 ` Jesse Barnes [this message]
2008-10-24 21:24 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810241418.38733.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=benli@broadcom.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).