From: David Miller <davem@davemloft.net>
To: zbr@ioremap.net
Cc: hamid.jafarian@gmail.com, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org, pablo@netfilter.org, kaber@trash.net,
jengelh@medozas.de, rusty@rustcorp.com.au, laforge@gnumonks.org,
eric@inl.fr, kadlec@blackhole.kfki.hu, azez@ufomechanic.net
Subject: Re: [PATCH 00/09]IPtablestng/Kernel - New Framework For IPtables
Date: Mon, 27 Oct 2008 17:02:11 -0700 (PDT) [thread overview]
Message-ID: <20081027.170211.119803913.davem@davemloft.net> (raw)
In-Reply-To: <20081028000044.GA16721@ioremap.net>
From: Evgeniy Polyakov <zbr@ioremap.net>
Date: Tue, 28 Oct 2008 03:00:44 +0300
> On Mon, Oct 27, 2008 at 07:58:33AM +0330, hamid jafarian (hamid.jafarian@gmail.com) wrote:
> > New Framework for IPtables
>
> Frankly saying your codying style is way out of expected range of
> allowed glitches, so it is quite hard to review the whole thing. Please
> update it to at least remotely match existing code. Also I noticed you
> do not use list iteration functions sometimes and replaces them with
> direct access to next/prev pointers, which is not a good idea.
And also please remove me from the CC: list as I have zero interest
in these patches.
Thanks.
next prev parent reply other threads:[~2008-10-28 0:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 4:28 [PATCH 00/09]IPtablestng/Kernel - New Framework For IPtables hamid jafarian
2008-10-28 0:00 ` Evgeniy Polyakov
2008-10-28 0:02 ` David Miller [this message]
2008-10-28 10:02 ` hamid jafarian
2008-10-28 10:43 ` Evgeniy Polyakov
2008-10-28 12:07 ` Patrick McHardy
2008-10-28 12:25 ` Evgeniy Polyakov
2008-10-28 12:30 ` Patrick McHardy
2008-10-28 12:43 ` Evgeniy Polyakov
2008-10-28 12:57 ` hamid jafarian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027.170211.119803913.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=azez@ufomechanic.net \
--cc=eric@inl.fr \
--cc=hamid.jafarian@gmail.com \
--cc=jengelh@medozas.de \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=laforge@gnumonks.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=rusty@rustcorp.com.au \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).