From: David Miller <davem@davemloft.net>
To: paulmck@linux.vnet.ibm.com
Cc: adobriyan@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: don't use INIT_RCU_HEAD
Date: Tue, 28 Oct 2008 13:25:21 -0700 (PDT) [thread overview]
Message-ID: <20081028.132521.120536910.davem@davemloft.net> (raw)
In-Reply-To: <20081028161017.GF6779@linux.vnet.ibm.com>
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Date: Tue, 28 Oct 2008 09:10:17 -0700
> On Tue, Oct 28, 2008 at 04:31:24PM +0300, Alexey Dobriyan wrote:
> > call_rcu() will unconditionally rewrite RCU head anyway.
> > Applies to
> > struct neigh_parms
> > struct neigh_table
> > struct net
> > struct cipso_v4_doi
> > struct in_ifaddr
> > struct in_device
> > rt->u.dst
>
> Assuming that no code outside of RCU is testing the rcu_head fields...
> That would usually be a bad idea in any case, as call_rcu() makes no
> guarantee about the values of these fields after the callback is invoked.
> Furthermore, there have been serious proposals that would change the
> call_rcu() field names and layout.
>
> Therefore:
>
> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
I've applied this patch, thanks everyone.
prev parent reply other threads:[~2008-10-28 20:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 13:31 [PATCH] net: don't use INIT_RCU_HEAD Alexey Dobriyan
2008-10-28 15:29 ` Patrick McHardy
2008-10-28 15:43 ` Alexey Dobriyan
2008-10-28 16:05 ` Paul E. McKenney
2008-10-28 16:10 ` Paul E. McKenney
2008-10-28 20:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081028.132521.120536910.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).