From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Patrick McHardy <kaber@trash.net>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] net: don't use INIT_RCU_HEAD
Date: Tue, 28 Oct 2008 09:05:48 -0700 [thread overview]
Message-ID: <20081028160548.GE6779@linux.vnet.ibm.com> (raw)
In-Reply-To: <20081028154341.GA22583@x200.localdomain>
On Tue, Oct 28, 2008 at 06:43:41PM +0300, Alexey Dobriyan wrote:
> On Tue, Oct 28, 2008 at 04:29:06PM +0100, Patrick McHardy wrote:
> > Alexey Dobriyan wrote:
> >> call_rcu() will unconditionally rewrite RCU head anyway.
> >> Applies to struct neigh_parms
> >> struct neigh_table
> >> struct net
> >> struct cipso_v4_doi
> >> struct in_ifaddr
> >> struct in_device
> >> rt->u.dst
> >
> > It would probably make sense to get a statement from Paul
> > whether this might be required in the future, f.i. for some
> > debugging feature.
>
> Let's cc him :-)
Can't say that I would be all that upset if INIT_RCU_HEAD() were to
simply vanish. So I have no problem with it being removed from the
above functions.
Suppose I might as well find the original and Ack it. ;-)
Thanx, Paul
next prev parent reply other threads:[~2008-10-28 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 13:31 [PATCH] net: don't use INIT_RCU_HEAD Alexey Dobriyan
2008-10-28 15:29 ` Patrick McHardy
2008-10-28 15:43 ` Alexey Dobriyan
2008-10-28 16:05 ` Paul E. McKenney [this message]
2008-10-28 16:10 ` Paul E. McKenney
2008-10-28 20:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081028160548.GE6779@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).