netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: jarkao2@gmail.com, xiaosuo@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] HTB updates class's bstats in one place
Date: Wed, 29 Oct 2008 11:22:15 -0700 (PDT)	[thread overview]
Message-ID: <20081029.112215.33710480.davem@davemloft.net> (raw)
In-Reply-To: <49083BF5.5090606@trash.net>

From: Patrick McHardy <kaber@trash.net>
Date: Wed, 29 Oct 2008 11:33:25 +0100

> Jarek Poplawski wrote:
> > On the other hand, it seems with shaping qdiscs they are more useful
> > to query dequeue rates.
> 
> Only for purely informational purposes, for policing you'd want to
> use arrival rates. Since there are no users of estimators in the kernel
> besides policers (which use seperate ones), the point is not terribly
> important. But I would prefer to not start introducing (or extending)
> inconsistencies among qdisc implementations here, that will only make
> it harder in case someone finally implements something useful with
> estimators.

I agree with Patrick %100

  reply	other threads:[~2008-10-29 18:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29  8:54 [PATCH] HTB updates class's bstats in one place Changli Gao
2008-10-29  9:01 ` Patrick McHardy
2008-10-29  9:09   ` Changli Gao
2008-10-29  9:19     ` Patrick McHardy
2008-10-29 10:23       ` Jarek Poplawski
2008-10-29 10:33         ` Patrick McHardy
2008-10-29 18:22           ` David Miller [this message]
2008-10-30  1:03           ` Changli Gao
2008-10-30  7:11             ` Patrick McHardy
2008-10-30  9:11               ` Changli Gao
2008-10-30  9:21                 ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081029.112215.33710480.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jarkao2@gmail.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=xiaosuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).