From: Jarek Poplawski <jarkao2@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Changli Gao <xiaosuo@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] HTB updates class's bstats in one place
Date: Wed, 29 Oct 2008 10:23:56 +0000 [thread overview]
Message-ID: <20081029102356.GA6165@ff.dom.local> (raw)
In-Reply-To: <49082AA5.20801@trash.net>
On 29-10-2008 10:19, Patrick McHardy wrote:
> Changli Gao wrote:
>> On Wed, Oct 29, 2008 at 5:01 PM, Patrick McHardy <kaber@trash.net> wrote:
>>> The estimators needs
>>> this since they're estimating the arrival rate.
>>>
>>>
>> I do not agree with you. TC is only for sending packets. Why does its
>> estimator estimating the arrival rate?
>
> I suppose because they were intended for policing.
On the other hand, it seems with shaping qdiscs they are more useful
to query dequeue rates. BTW, after this patch there is still
"a statistics bug": the statistics data of a qdisc can differ from
its classes.
Jarek P.
next prev parent reply other threads:[~2008-10-29 10:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 8:54 [PATCH] HTB updates class's bstats in one place Changli Gao
2008-10-29 9:01 ` Patrick McHardy
2008-10-29 9:09 ` Changli Gao
2008-10-29 9:19 ` Patrick McHardy
2008-10-29 10:23 ` Jarek Poplawski [this message]
2008-10-29 10:33 ` Patrick McHardy
2008-10-29 18:22 ` David Miller
2008-10-30 1:03 ` Changli Gao
2008-10-30 7:11 ` Patrick McHardy
2008-10-30 9:11 ` Changli Gao
2008-10-30 9:21 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029102356.GA6165@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).