netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: "Injong Rhee" <rhee@eos.ncsu.edu>, David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>
Subject: [PATCH] tcp: mark BIC as experimental
Date: Thu, 30 Oct 2008 08:36:41 -0700	[thread overview]
Message-ID: <20081030083641.55e936b0@extreme> (raw)
In-Reply-To: <006001c93a0d$477d4e30$4a580e98@ncsu2cc0c3fa00>

Change the configuration defaults to mark BIC as experimental.
BIC is too aggressive and was replaced by CUBIC. Debian was picking
BIC in their default config (should be fixed by now), but the configuration
documentation did not make it explicit that this was a bad idea.

Also update the URLs in the configuration documentation to current
locations.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/net/ipv4/Kconfig	2008-10-29 14:58:40.000000000 -0700
+++ b/net/ipv4/Kconfig	2008-10-30 08:18:08.000000000 -0700
@@ -437,7 +437,8 @@ if TCP_CONG_ADVANCED
 
 config TCP_CONG_BIC
 	tristate "Binary Increase Congestion (BIC) control"
-	default m
+	depends on EXPERIMENTAL
+	default n
 	---help---
 	BIC-TCP is a sender-side only change that ensures a linear RTT
 	fairness under large windows while offering both scalability and
@@ -447,15 +448,24 @@ config TCP_CONG_BIC
 	increment ensures linear RTT fairness as well as good
 	scalability. Under small congestion windows, binary search
 	increase provides TCP friendliness.
-	See http://www.csc.ncsu.edu/faculty/rhee/export/bitcp/
+
+	BIC growth function is too aggressive and should not be used
+	except for testing and comparision, use CUBIC instead.
+
+	For further details see:
+           http://netsrv.csc.ncsu.edu/twiki/bin/view/Main/BIC
 
 config TCP_CONG_CUBIC
 	tristate "CUBIC TCP"
 	default y
 	---help---
-	This is version 2.0 of BIC-TCP which uses a cubic growth function
-	among other techniques.
-	See http://www.csc.ncsu.edu/faculty/rhee/export/bitcp/cubic-paper.pdf
+	CUBIC TCP is an sender-side only modification to the congestion control
+	algothrim improved versions on the growth function of BIC and has an
+	improved slow start algoritm, called HyStart.
+
+	For further details see:
+           http://netsrv.csc.ncsu.edu/twiki/bin/view/Main/BIC
+
 
 config TCP_CONG_WESTWOOD
 	tristate "TCP Westwood+"
@@ -581,9 +591,6 @@ choice
 	  Select the TCP congestion control that will be used by default
 	  for all connections.
 
-	config DEFAULT_BIC
-		bool "Bic" if TCP_CONG_BIC=y
-
 	config DEFAULT_CUBIC
 		bool "Cubic" if TCP_CONG_CUBIC=y
 
@@ -610,7 +617,6 @@ config TCP_CONG_CUBIC
 
 config DEFAULT_TCP_CONG
 	string
-	default "bic" if DEFAULT_BIC
 	default "cubic" if DEFAULT_CUBIC
 	default "htcp" if DEFAULT_HTCP
 	default "vegas" if DEFAULT_VEGAS

  parent reply	other threads:[~2008-10-30 15:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 21:28 [PATCH] CUBIC v2.3 with new improved slow start Injong Rhee
2008-10-29 22:39 ` Stephen Hemminger
2008-10-29 23:14   ` Injong Rhee
2008-10-29 23:40     ` Stephen Hemminger
2008-10-29 23:53       ` Rick Jones
2008-10-30  0:54         ` Injong Rhee
2008-10-30  1:08         ` Rick Jones
2008-10-29 23:45     ` David Miller
2008-10-30 15:36 ` Stephen Hemminger [this message]
2008-10-31  7:50   ` [PATCH] tcp: mark BIC as experimental David Miller
2008-10-31 16:41     ` Stephen Hemminger
2008-10-31 19:04       ` David Miller
2008-10-31 19:16     ` [RFC] tcp: make H-TCP the default congestion control Stephen Hemminger
2008-10-31 19:43       ` Sangtae Ha
2008-10-31 20:02         ` rhee
2008-11-02  4:29       ` David Miller
2008-11-02  7:27 ` [PATCH] CUBIC v2.3 with new improved slow start David Miller
2008-11-03 22:19   ` Sangtae Ha
2008-11-03 22:49     ` Stephen Hemminger
2008-11-04  1:12     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081030083641.55e936b0@extreme \
    --to=shemminger@vyatta.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rhee@eos.ncsu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).