From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Allan, Bruce W" <bruce.w.allan@intel.com>
Cc: Jeff Garzik <jeff@garzik.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] [PCI] move ICHx GbE NVM write-protection from e1000e to PCI quirk
Date: Thu, 30 Oct 2008 09:16:00 -0700 [thread overview]
Message-ID: <200810300916.01468.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <B27EBC40D200ED48A3F4CC2EBEABAE0B20B38046@orsmsx501.amr.corp.intel.com>
On Monday, October 27, 2008 1:26 pm Allan, Bruce W wrote:
> >> This PCI quirk is put in ./drivers/net/e1000e in order to share
> >> defines and structs found in the driver source, and is only applicable
> >> to ICHx GbE LOMs supported by that driver anyway.
> >
> >Seems to be it is not difficult to put it into drivers/pci/quirks.c,
> >where it belongs.
> >
> > Jeff
>
> Yes, it wouldn't be difficult to put it elsewhere but does it really belong
> in drivers/pci/quirks.c? The quirk is applicable only to the GbE LOM found
> on Intel ICH8/9/10-based platforms so one could argue it should be in
> arch-specific code (arch/x86/pci/fixup.c). OTOH, quirks in driver
> directories are not unprecedented (e.g. drivers/clocksource/acpi_pm.c,
> drivers/usb/host/pci-quirks.c). I patched it into the driver's directory
> as it would be an obvious reminder when adding support for future parts to
> check whether the quirk is applicable and update the list of devices
> accordingly.
>
> So, what is the "right" place?
If you think it's likely to apply to future devices as well, I'd say you may
as well keep it in the driver.
Jesse
next prev parent reply other threads:[~2008-10-30 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 1:13 [PATCH] [PCI] move ICHx GbE NVM write-protection from e1000e to PCI quirk Jeff Kirsher
2008-10-25 1:27 ` Jeff Kirsher
2008-10-25 2:22 ` Jeff Garzik
2008-10-27 20:26 ` Allan, Bruce W
2008-10-30 16:16 ` Jesse Barnes [this message]
2008-10-30 18:29 ` Allan, Bruce W
2008-10-30 18:35 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810300916.01468.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).