From: Jarek Poplawski <jarkao2@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: [PATCH 0/6 RESEND] Add qdisc->ops->peek() support.
Date: Thu, 30 Oct 2008 13:05:18 +0000 [thread overview]
Message-ID: <20081030130518.GA22853@ff.dom.local> (raw)
[Subject: Re: [PATCH 00/14]: Killing qdisc->ops->requeue().]
On Tue, Oct 14, 2008 at 10:44:13PM +0200, Patrick McHardy wrote:
...
> I think we really need a peek operation since most qdiscs do have
> some internal priorization. The question is whether all qdiscs need
> it; I tend to think no. Plugging two non-work-conserving qdiscs
> together doesn't make much sense, so we could just prevent this.
> This means we would only need to add ->peek support to the
> work-conserving qdiscs, which looks pretty easy in all cases.
> We actually don't even have to prevent plugging two non-work-conserving
> qdiscs, the ones that need the peek operation could just check whether
> the inner qdisc supports it.
>
> Just as a demonstration how easy adding a peek operation to the
> work-conserving qdiscs actually is. It doesn't need to keep or change
> any internal state in many cases thanks to the guarantee that the
> packet will either be dequeued or, if another packet arrives, the
> upper qdisc will immediately ->peek again to reevaluate the state.
So here is a re-try.
PATCH 6/6 adds my simple idea not to prevent even nonsense configs.
It is optional.
This resend is redone against current net-next with slightly changed
patches 3/6 (check added in register_qdisc()) and 4/6 (teql_peek()
made nonfunctional), according to Patric's suggestions, I hope.
Thanks,
Jarek P.
PS: after this patchset only netem_enqueue() needs qdisc->requeue(),
but this will be handled by a separate patch.
include/net/sch_generic.h | 29 +++++++++++++++++++++++++++++
net/sched/sch_api.c | 12 ++++++++++++
net/sched/sch_atm.c | 23 ++++++++++++++++++-----
net/sched/sch_blackhole.c | 1 +
net/sched/sch_cbq.c | 1 +
net/sched/sch_dsmark.c | 10 ++++++++++
net/sched/sch_fifo.c | 2 ++
net/sched/sch_generic.c | 16 ++++++++++++++++
net/sched/sch_gred.c | 1 +
net/sched/sch_hfsc.c | 15 ++++-----------
net/sched/sch_htb.c | 1 +
net/sched/sch_multiq.c | 29 +++++++++++++++++++++++++++++
net/sched/sch_netem.c | 15 +++++++--------
net/sched/sch_prio.c | 14 ++++++++++++++
net/sched/sch_red.c | 9 +++++++++
net/sched/sch_sfq.c | 12 ++++++++++++
net/sched/sch_tbf.c | 13 ++++++-------
net/sched/sch_teql.c | 8 ++++++++
18 files changed, 180 insertions(+), 31 deletions(-)
next reply other threads:[~2008-10-30 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 13:05 Jarek Poplawski [this message]
2008-10-30 13:25 ` [PATCH 0/6 RESEND] Add qdisc->ops->peek() support Jarek Poplawski
2008-10-31 7:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030130518.GA22853@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).