From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John W. Linville" Subject: Re: [PATCH 16/18] netdevice zd1201: Convert directly reference of netdev->priv to netdev->ml_priv Date: Fri, 31 Oct 2008 14:22:07 -0400 Message-ID: <20081031182207.GD4310@tuxdriver.com> References: <48C0A219.2030004@cn.fujitsu.com> <48C0A7A0.9030200@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Jeff Garzik , NETDEV , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wang Chen Return-path: Content-Disposition: inline In-Reply-To: <48C0A7A0.9030200-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Fri, Sep 05, 2008 at 11:29:36AM +0800, Wang Chen wrote: > We have some reasons to kill netdev->priv: > 1. netdev->priv is equal to netdev_priv(). > 2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously > netdev_priv() is more flexible than netdev->priv. > But we cann't kill netdev->priv, because so many drivers reference to it > directly. > > OK, becasue Dave S. Miller said, "every direct netdev->priv usage is a bug", > and I want to kill netdev->priv later, I decided to convert all the direct > reference of netdev->priv first. > > Different to readonly reference of netdev->priv, in this driver, netdev->priv > was changed. I use netdev->ml_priv to replace netdev->priv. > > Signed-off-by: Wang Chen I don't think this is the right approach for this driver. Alternative patch to follow... John -- John W. Linville Linux should be at the core linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org of your literate lifestyle. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html