netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <zbr@ioremap.net>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Evgeniy Polyakov <s0mbre@tservice.net.ru>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@elte.hu>, David Miller <davem@davemloft.net>,
	Christoph Lameter <cl@linux-foundation.org>,
	Matthew Wilcox <matthew@wil.cx>
Subject: Re: SLAB vs. SLUB tbench regression (Was: [tbench regression fixes]: digging out smelly deadmen.)
Date: Fri, 31 Oct 2008 21:22:54 +0300	[thread overview]
Message-ID: <20081031182253.GA32340@ioremap.net> (raw)
In-Reply-To: <84144f020810310728j1f3b8a99se428ec55b0c165b5@mail.gmail.com>

Hi Pekka.

On Fri, Oct 31, 2008 at 04:28:57PM +0200, Pekka Enberg (penberg@cs.helsinki.fi) wrote:
> As you've already pointed out in private and in your blog, some part
> of the tbench regression comes from SLUB vs. SLAB as well. Looks like
> I can reproduce the regression locally as well:
> 
>   [ 8 clients and tbench_srv on the same machine on 2-way x86-64 ]
> 
>                   min      max      avg      sd
>   2.6.28-rc2-slab 234.57   244.88   242.68   0.71
>   2.6.28-rc2-slub 227.44   240.90   239.08   0.78
> 
> Oprofile seems to be busted for 2.6.28-rc2 so I'll follow up on this
> as soon as that's settled.
> 
> Btw, just as one more data point, I accidentally tested with just 2
> clients at first and SLUB actually beat SLAB.

Looks like under the allocation/freeing pressure some tricky part of
slub starts slowing things down, while at usual rate amount of operations
is smaller, so slub gets its optimized results... Just a handwaving
though.

Tbench regression is not related to slab/slub fight though, since I
always used slab in tests (if not specially tested slub), but of course
fixing this issue in the more and more common allocator would be just
great. Thanks for working on this issue Pekka.

-- 
	Evgeniy Polyakov

      parent reply	other threads:[~2008-10-31 18:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-31 14:28 SLAB vs. SLUB tbench regression (Was: [tbench regression fixes]: digging out smelly deadmen.) Pekka Enberg
2008-10-31 15:08 ` Pekka Enberg
2008-10-31 18:22 ` Evgeniy Polyakov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081031182253.GA32340@ioremap.net \
    --to=zbr@ioremap.net \
    --cc=a.p.zijlstra@chello.nl \
    --cc=cl@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=s0mbre@tservice.net.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).