From: Alexey Dobriyan <adobriyan@gmail.com>
To: davem@davemloft.net, herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: [PATCH] Fix ESP SA loading (by default)
Date: Sat, 1 Nov 2008 07:37:37 +0300 [thread overview]
Message-ID: <20081101043737.GA1621@x200.localdomain> (raw)
digest_null algorithm is now mandatory for ESP.
Steps to reproduce:
kernel with CONFIG_CRYPTO_NULL=n
#!/usr/sbin/setkey -f
flush;
spdflush;
add 192.168.0.1 192.168.0.42 esp 15701 -E 3des-cbc "123456789012123456789012";
This will successfully create ESP SA.
Now, apply commit 38320c70d282be1997a5204c7c7fe14c3aa6bfaa aka
"[IPSEC]: Use crypto_aead and authenc in ESP" and ESP SAs won't be created.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
Ewwww, such a cool bug turned out to be configuration issue!
And I was thinking why on earth why Debian 2.6.26 based kernel is OK,
but 2.6.25-rc1 (!) fails. Ditto for minimalistic config for testing with KVM.
Not mentioning Debian's gcc creating references to __ucmdhowitiscalled up
and including to 2.6.18 and screwing bisection hard way.
Now that I passed first IPsec tutorial, allow me to start netns XFRM work :^)
net/ipv4/Kconfig | 1 +
net/ipv6/Kconfig | 1 +
2 files changed, 2 insertions(+)
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -346,6 +346,7 @@ config INET_ESP
select CRYPTO_AUTHENC
select CRYPTO_HMAC
select CRYPTO_MD5
+ select CRYPTO_NULL
select CRYPTO_CBC
select CRYPTO_SHA1
select CRYPTO_DES
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -86,6 +86,7 @@ config INET6_ESP
select CRYPTO_AUTHENC
select CRYPTO_HMAC
select CRYPTO_MD5
+ select CRYPTO_NULL
select CRYPTO_CBC
select CRYPTO_SHA1
select CRYPTO_DES
next reply other threads:[~2008-11-01 4:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 4:37 Alexey Dobriyan [this message]
2008-11-01 5:04 ` [PATCH] Fix ESP SA loading (by default) Herbert Xu
2008-11-01 11:38 ` Alexey Dobriyan
2008-11-01 11:50 ` Herbert Xu
2008-11-02 4:33 ` David Miller
2008-11-03 0:16 ` Alexey Dobriyan
2008-11-03 1:04 ` Herbert Xu
2008-11-05 9:31 ` David Miller
2008-11-05 9:38 ` Herbert Xu
2008-11-05 9:54 ` Alexey Dobriyan
2008-11-05 9:55 ` David Miller
2008-11-05 10:03 ` Patrick McHardy
2008-11-05 10:26 ` David Miller
2008-11-05 10:30 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081101043737.GA1621@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox