netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: netdev@vger.kernel.org
Subject: warnings from recent format patch
Date: Sun, 2 Nov 2008 16:33:11 -0800	[thread overview]
Message-ID: <20081102163311.44e4ddef@extreme> (raw)

Even if you can't run it, please compile and run sparse on your
code.

 CC [M]  net/sunrpc/xprtsock.o
net/sunrpc/xprtsock.c: In function ‘xs_format_ipv4_peer_addresses’:
net/sunrpc/xprtsock.c:287: warning: too many arguments for format

static void xs_format_ipv4_peer_addresses(struct rpc_xprt *xprt,
					  const char *protocol,
					  const char *netid)
{
	struct sockaddr_in *addr = xs_addr_in(xprt);
	char *buf;

	buf = kzalloc(20, GFP_KERNEL);
	if (buf) {
		snprintf(buf, 20, "pI4", &addr->sin_addr.s_addr);
                                   ^
                                   missing %

             reply	other threads:[~2008-11-03  0:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-03  0:33 Stephen Hemminger [this message]
2008-11-03  7:57 ` warnings from recent format patch David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081102163311.44e4ddef@extreme \
    --to=shemminger@vyatta.com \
    --cc=harvey.harrison@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).