From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: arno@natisbad.org, netdev@vger.kernel.org,
andreas.steffen@strongswan.org, martin@strongswan.org,
kazunori@miyazawa.org
Subject: Re: [PATCH] Have af-specific init_tempsel() initialize family field of temporary selector
Date: Tue, 04 Nov 2008 14:49:26 -0800 (PST) [thread overview]
Message-ID: <20081104.144926.65584309.davem@davemloft.net> (raw)
In-Reply-To: <20081104115228.GC11049@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 4 Nov 2008 19:52:28 +0800
> On Tue, Nov 04, 2008 at 12:46:44PM +0100, Arnaud Ebalard wrote:
> >
> > Sorry Herbert, my initial comment was misleading: the family is not set
> > in the selectors provided in the *XFRM_MSG_ACQUIRE*, which is not MIPv6
> > related. I could check again, but I think the patch below will impact
> > all native key managers. Or did I miss something and there is a specific
> > reason why MIPv6 folks may be impacted?
>
> Indeed, you're right. I was thinking of SA creation.
>
> > >> Reported-by: Andreas Steffen <andreas.steffen@strongswan.org>
> > >> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied to net-2.6, thanks.
prev parent reply other threads:[~2008-11-04 22:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 10:24 [PATCH] Have af-specific init_tempsel() initialize family field of temporary selector Arnaud Ebalard
2008-11-04 11:24 ` Herbert Xu
2008-11-04 11:46 ` Arnaud Ebalard
2008-11-04 11:52 ` Herbert Xu
2008-11-04 22:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081104.144926.65584309.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreas.steffen@strongswan.org \
--cc=arno@natisbad.org \
--cc=herbert@gondor.apana.org.au \
--cc=kazunori@miyazawa.org \
--cc=martin@strongswan.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).