From: David Miller <davem@davemloft.net>
To: benjamin.thery@bull.net
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: fix run pending DAD when interface becomes ready
Date: Tue, 04 Nov 2008 14:51:22 -0800 (PST) [thread overview]
Message-ID: <20081104.145122.25920326.davem@davemloft.net> (raw)
In-Reply-To: <20081104135551.916564770@nptl.frec.bull.fr>
From: Benjamin Thery <benjamin.thery@bull.net>
Date: Tue, 04 Nov 2008 14:55:50 +0100
> I think there's a bug in net/ipv6/addrconf.c, addrconf_notify():
> addrconf_dad_run() is not always run when the interface is flagged IF_READY.
> Currently it is only run when receiving NETDEV_CHANGE event. Looks like
> some (virtual) devices doesn't send this event when becoming up.
>
> For both NETDEV_UP and NETDEV_CHANGE events, when the interface becomes
> ready, run_pending should be set to 1. Patch below.
>
> 'run_pending = 1' could be moved below the if/else block but it makes
> the code less readable.
I wonder if we should instead make the virtual devices emit
the missing event?
next prev parent reply other threads:[~2008-11-04 22:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081104135549.981972492@nptl.frec.bull.fr>
2008-11-04 13:55 ` [PATCH] ipv6: fix run pending DAD when interface becomes ready Benjamin Thery
2008-11-04 22:51 ` David Miller [this message]
2008-11-05 9:44 ` David Miller
2008-11-05 10:28 ` Benjamin Thery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081104.145122.25920326.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benjamin.thery@bull.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).