From: Stephen Hemminger <shemminger@vyatta.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: Patrick McHardy <kaber@trash.net>,
David Miller <davem@davemloft.net>,
herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] sch_netem: Remove classful functionality
Date: Tue, 4 Nov 2008 08:25:10 -0800 [thread overview]
Message-ID: <20081104082510.2dd57d04@extreme> (raw)
In-Reply-To: <20081104095642.GA4498@ff.dom.local>
On Tue, 4 Nov 2008 09:56:42 +0000
Jarek Poplawski <jarkao2@gmail.com> wrote:
> On Mon, Nov 03, 2008 at 09:06:30AM -0800, Stephen Hemminger wrote:
> > On Mon, 03 Nov 2008 12:20:25 +0100
> > Patrick McHardy <kaber@trash.net> wrote:
> >
> > > Jarek Poplawski wrote:
> > > > On Sun, Nov 02, 2008 at 12:37:00AM -0700, David Miller wrote:
> > > >> From: Jarek Poplawski <jarkao2@gmail.com>
> > > >> Date: Fri, 31 Oct 2008 13:20:10 +0000
> > > >>
> > > >> Jarek, I applied this patch and your second one to net-next-2.6
> > > >>
> > > >> But I did this only because I trust that you will address Stephen's
> > > >> feedback wrt. making existing netem functionality available in
> > > >> some way.
> > > >>
> > > >> Otherwise I'll have to revert these changes.
> > > >
> > > > Hmm... I thought there was kind of RFC for this, and it looked like
> > > > Patrick's idea won 100% of votes, but I'm not good in counting...
> > > >
> > > > http://marc.info/?l=linux-netdev&m=122469801712438&w=2
> > > > http://marc.info/?l=linux-netdev&m=122469674709761&w=2
> > > >
> > > > Anyway, IMHO adding TBF etc. functionalities to tfifo doesn't make
> > > > much sense, and if they are really needed it's better to revert
> > > > these patches and chose one of the other ways of doing reorder
> > > > proposed in this earlier thread.
> > >
> > > Whats wrong with simply using TBF as parent qdisc of netem?
> >
> > It works but does something slightly different.
> >
> > netem inside TBF is like long delay network followed by choke on last hop
> > TBF inside netem was like choke on uplink followed by long delay network.
>
> David, this makes sense to me, so please revert these two patches.
> (Then, I think we're still at RFC stage.)
>
> Thanks.
> Jarek P.
Keep Jarek's patch, I am working on dummynet compatiable rate control.
next prev parent reply other threads:[~2008-11-04 16:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 13:20 [PATCH 1/2] sch_netem: Remove classful functionality Jarek Poplawski
2008-10-31 16:45 ` Stephen Hemminger
2008-11-02 7:37 ` David Miller
2008-11-03 8:29 ` Jarek Poplawski
2008-11-03 11:20 ` Patrick McHardy
2008-11-03 17:06 ` Stephen Hemminger
2008-11-04 9:56 ` Jarek Poplawski
2008-11-04 16:25 ` Stephen Hemminger [this message]
2008-11-04 21:42 ` Patrick McHardy
2008-11-04 11:04 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081104082510.2dd57d04@extreme \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).