Re: [PATCH] ipv6: fix run pending DAD when interface becomes ready

[David Miller <davem@davemloft.net>]

From: David Miller <davem@davemloft.net>
Date: Tue, 04 Nov 2008 14:51:22 -0800 (PST)

> From: Benjamin Thery <benjamin.thery@bull.net>
> Date: Tue, 04 Nov 2008 14:55:50 +0100
> 
> > I think there's a bug in net/ipv6/addrconf.c, addrconf_notify():
> > addrconf_dad_run() is not always run when the interface is flagged IF_READY.
> > Currently it is only run when receiving NETDEV_CHANGE event. Looks like
> > some (virtual) devices doesn't send this event when becoming up.
> > 
> > For both NETDEV_UP and NETDEV_CHANGE events, when the interface becomes
> > ready, run_pending should be set to 1. Patch below.
> > 
> > 'run_pending = 1' could be moved below the if/else block but it makes 
> > the code less readable.
> 
> I wonder if we should instead make the virtual devices emit
> the missing event?

In any event, for the time being, I'm going to apply
Benjamin's patch to fix this problem.

It makes the function in question logically consistent
in that now everything that can cause IF_READY to become
set will also cause run_pending work to run.