From: Arnd Bergmann <arnd@arndb.de>
To: Ira Snyder <iws@ovro.caltech.edu>
Cc: linuxppc-dev@ozlabs.org,
Stephen Hemminger <shemminger@vyatta.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan-Bernd Themann <THEMANN@de.ibm.com>
Subject: Re: [PATCH RFC v2] net: add PCINet driver
Date: Wed, 5 Nov 2008 14:19:52 +0100 [thread overview]
Message-ID: <200811051419.53194.arnd@arndb.de> (raw)
In-Reply-To: <20081104222927.GE4641@ovro.caltech.edu>
On Tuesday 04 November 2008, Ira Snyder wrote:
> So, since interrupts are disabled while my interrupt handler is running,
> I think I should be able to use spin_lock() and spin_unlock(), correct?
yes.
> But sparse gives me the following warning:
> wqt.c:185:9: warning: context imbalance in 'wqt_interrupt': wrong count at exit
> wqt.c:185:9: context 'lock': wanted 0, got 1
>
> If I'm using spin_lock_irqsave() and spin_lock_irqrestore() I do not get
> the same warnings. Therefore I must have some misunderstanding :)
I've seen something like that before, I think it was a bug either in
sparse or in the powerpc platform code. Try updating both the kernel
and sparse and see if it still happens.
Arnd <><
next prev parent reply other threads:[~2008-11-05 13:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 20:20 [PATCH RFC v2] net: add PCINet driver Ira Snyder
2008-10-29 20:25 ` Stephen Hemminger
2008-10-29 20:50 ` Ira Snyder
2008-10-29 20:54 ` Scott Wood
2008-10-29 21:13 ` Ira Snyder
2008-10-29 21:43 ` Matt Sealey
2008-10-29 22:22 ` Ira Snyder
2008-11-04 12:09 ` Arnd Bergmann
2008-11-04 17:34 ` Ira Snyder
2008-11-04 20:23 ` Arnd Bergmann
2008-11-04 21:25 ` Ira Snyder
2008-11-05 13:50 ` Arnd Bergmann
2008-11-05 19:32 ` Ira Snyder
2008-11-04 22:29 ` Ira Snyder
2008-11-05 13:19 ` Arnd Bergmann [this message]
2008-11-05 19:18 ` Ira Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811051419.53194.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=THEMANN@de.ibm.com \
--cc=iws@ovro.caltech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).