From: Rusty Russell <rusty@rustcorp.com.au>
To: Mark McLoughlin <markmc@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] virtio_net: don't set NETIF_F_FRAGLIST
Date: Thu, 6 Nov 2008 08:53:11 +1100 [thread overview]
Message-ID: <200811060853.11566.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1225888486-977-1-git-send-email-markmc@redhat.com>
On Wednesday 05 November 2008 23:34:46 Mark McLoughlin wrote:
> We don't handle skb_shared_info->frag_list, so we shouldn't
> be setting the NETIF_F_FRAGLIST flag.
We don't?
skb_to_sgvec() should handle it OK, is there some subtlety I'm missing?
Rusty.
next prev parent reply other threads:[~2008-11-05 21:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 12:34 [PATCH] virtio_net: don't set NETIF_F_FRAGLIST Mark McLoughlin
2008-11-05 21:53 ` Rusty Russell [this message]
2008-11-06 10:10 ` Mark McLoughlin
2008-11-06 5:43 ` Jeff Garzik
2008-11-06 10:12 ` Mark McLoughlin
2008-11-06 10:48 ` Jeff Garzik
2008-11-06 10:56 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811060853.11566.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).