From: Michael Buesch <mb@bu3sch.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
Johannes Berg <johannes@sipsolutions.net>,
Mike Frysinger <vapier@gentoo.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SSB: make it depend on PCI
Date: Sun, 9 Nov 2008 12:49:51 +0100 [thread overview]
Message-ID: <200811091249.52071.mb@bu3sch.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0811091149280.19341@anakin>
On Sunday 09 November 2008 11:51:37 Geert Uytterhoeven wrote:
> I had the same issue on m68k, not only with SSB but also with other legacy
> drivers (hp100 Ethernet, AIC7xxx SCSI). It was fixed in commit
> 998aaf01c6f6f3dffc1ea9e7b20b131e38fdbc78 ("m68k: <asm/pci.h> needs
> <asm-generic/pci-dma-compat.h>").
Ok, nice.
I'd suggest we additionally fix the architectures this way.
My patch already is on its way upstream and I think that's OK.
The codepaths that it #ifdefs out are dead code on non-PCI, so I think
it's OK to #ifdef them.
--
Greetings Michael.
next prev parent reply other threads:[~2008-11-09 11:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 9:51 [PATCH] SSB: make it depend on PCI Mike Frysinger
2008-11-06 11:07 ` Johannes Berg
2008-11-06 11:15 ` Mike Frysinger
2008-11-06 11:22 ` Johannes Berg
2008-11-06 11:26 ` Mike Frysinger
2008-11-06 11:29 ` Johannes Berg
2008-11-06 11:32 ` Mike Frysinger
2008-11-06 11:35 ` Johannes Berg
2008-11-06 16:59 ` Michael Buesch
2008-11-06 21:14 ` Mike Frysinger
2008-11-06 21:24 ` Michael Buesch
2008-11-06 16:56 ` Michael Buesch
2008-11-09 10:51 ` Geert Uytterhoeven
2008-11-09 11:49 ` Michael Buesch [this message]
2008-11-06 16:55 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811091249.52071.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=geert@linux-m68k.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vapier.adi@gmail.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).