From: David Miller <davem@davemloft.net>
To: mb@bu3sch.de
Cc: netdev@vger.kernel.org
Subject: Re: ssb: Fix DMA-API compilation for non-PCI systems
Date: Mon, 10 Nov 2008 13:52:31 -0800 (PST) [thread overview]
Message-ID: <20081110.135231.96349017.davem@davemloft.net> (raw)
I applied this since it's a build buster and we should
get it fixed quickly.
But as I look at this, the thing to really do here is get
rid of these stupid switch statements. None of it is needed.
The layer that sets up the SSB devices should simply save the
generic device pointer for the DMA entity into some new
->dma_dev struct member.
Then you just use generic dma_*() interfaces unilaterally. For PCI
devices it will "just work".
next reply other threads:[~2008-11-10 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 21:52 David Miller [this message]
2008-11-10 22:07 ` ssb: Fix DMA-API compilation for non-PCI systems Michael Buesch
2008-11-10 22:53 ` David Miller
2008-11-10 23:32 ` Michael Buesch
2008-11-11 8:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081110.135231.96349017.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).