From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: adobriyan@gmail.com, snakebyte@gmx.de, netdev@vger.kernel.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] net: fix /proc/net/snmp as memory corruptor
Date: Mon, 10 Nov 2008 21:43:25 -0800 (PST) [thread overview]
Message-ID: <20081110.214325.84371467.davem@davemloft.net> (raw)
In-Reply-To: <4915295B.4050102@cosmosbay.com>
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Sat, 08 Nov 2008 06:53:31 +0100
> [PATCH] net: fix /proc/net/snmp as memory corruptor
>
> icmpmsg_put() can happily corrupt kernel memory, using a static
> table and forgetting to reset an array index in a loop.
>
> Remove the static array since its not safe without proper locking.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
I've applied this version of the fix.
Thanks!
prev parent reply other threads:[~2008-11-11 5:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 0:22 seq_read bugs with ipmr Eric Sesterhenn
2008-11-08 1:02 ` Alexey Dobriyan
2008-11-08 2:52 ` Alexey Dobriyan
2008-11-08 3:36 ` [PATCH] net: fix /proc/net/snmp as memory corruptor Alexey Dobriyan
2008-11-08 5:53 ` Eric Dumazet
2008-11-08 6:22 ` Alexey Dobriyan
2008-11-08 6:42 ` Alexey Dobriyan
2008-11-08 9:48 ` Eric Sesterhenn
2008-11-08 19:53 ` David Stevens
2008-11-08 20:46 ` Eric Dumazet
2008-11-08 21:05 ` David Stevens
2008-11-09 8:25 ` Eric Dumazet
2008-11-11 5:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081110.214325.84371467.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dada1@cosmosbay.com \
--cc=netdev@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).