From: Samuel Ortiz <samuel@sortiz.org>
To: "Alex Villacís Lasso" <avillaci@ceibo.fiec.espol.edu.ec>
Cc: irda-users@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [irda-users] [1/3] IRDA: Create new field tx_extra in skbuff
Date: Mon, 10 Nov 2008 17:47:32 +0100 [thread overview]
Message-ID: <20081110164732.GA7511@sortiz.org> (raw)
In-Reply-To: <49185CBD.2040601@ceibo.fiec.espol.edu.ec>
Hi Alex,
On Mon, Nov 10, 2008 at 11:09:33AM -0500, Alex Villacís Lasso wrote:
> This patch and the other two that follow fix the issue for me under
> 2.6.28-rc3. Please comment on this, as I am messing around with the
> skbuff structure, which potentially affects all network stacks.
Adding 32 bytes to _all_ skbs is a no-no.
This is an IrDA specific issue, and it has to be fixed in an IrDA specific
way. My patches work with my irda-usb and mcs7780 dongles. If they dont for
you, then we should dump the kernel stack when we're hitting the problem of
not having reserved enough headroom for the irda cb.
Evgeniy's proposal could also be another solution.
Cheers,
Samuel.
next prev parent reply other threads:[~2008-11-10 16:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 16:09 [1/3] IRDA: Create new field tx_extra in skbuff Alex Villacís Lasso
2008-11-10 16:35 ` Evgeniy Polyakov
2008-11-10 16:55 ` Evgeniy Polyakov
[not found] ` <20081110165544.GB19804-i6C2adt8DTjR7s880joybQ@public.gmane.org>
2008-11-11 1:00 ` Samuel Ortiz
2008-11-11 6:22 ` [irda-users] " Evgeniy Polyakov
2008-11-10 16:47 ` Samuel Ortiz [this message]
2008-11-10 20:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081110164732.GA7511@sortiz.org \
--to=samuel@sortiz.org \
--cc=avillaci@ceibo.fiec.espol.edu.ec \
--cc=irda-users@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).