* SKB truesize bug
@ 2008-11-11 17:25 Stephen Hemminger
2008-11-12 1:37 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2008-11-11 17:25 UTC (permalink / raw)
To: Herbert Xu; +Cc: netdev
Is this bug fixed? is it in the 2.6.26.8 kernel?
http://bugzilla.kernel.org/show_bug.cgi?id=10996
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: SKB truesize bug
2008-11-11 17:25 SKB truesize bug Stephen Hemminger
@ 2008-11-12 1:37 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2008-11-12 1:37 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
On Tue, Nov 11, 2008 at 09:25:13AM -0800, Stephen Hemminger wrote:
> Is this bug fixed? is it in the 2.6.26.8 kernel?
No and yes.
We need to fix up the truesize when resizing packets for IPsec
processing.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: SKB truesize bug
2008-04-30 5:37 ` David Miller
@ 2008-11-20 11:59 ` Kostya B
2008-11-20 12:03 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Kostya B @ 2008-11-20 11:59 UTC (permalink / raw)
To: netdev
Hi,
Perhaps we should take a closer look on pskb_expand_head()
And add
+skb->truesize = size + sizeof(struct sk_buff);
Kostya
_________________________________________________________________
Invite your mail contacts to join your friends list with Windows Live Spaces. It's easy!
http://spaces.live.com/spacesapi.aspx?wx_action=create&wx_url=/friends.aspx&mkt=en-us
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: SKB truesize bug
2008-11-20 11:59 ` SKB truesize bug Kostya B
@ 2008-11-20 12:03 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2008-11-20 12:03 UTC (permalink / raw)
To: bkostya; +Cc: netdev
From: Kostya B <bkostya@hotmail.com>
Date: Thu, 20 Nov 2008 11:59:28 +0000
> Perhaps we should take a closer look on pskb_expand_head()
>
> And add
>
> +skb->truesize = size + sizeof(struct sk_buff);
You can't. If a socket is attached to the skb it's buffer
accounting will get corrupted if you modify skb->truesize.
This has been explained a thousand times on this list.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-11-20 12:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-11 17:25 SKB truesize bug Stephen Hemminger
2008-11-12 1:37 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2008-04-28 12:13 [PATCH][IPv4] UFO: prevent generation of chained skb Kostya B
2008-04-29 10:27 ` David Miller
2008-04-29 12:07 ` Herbert Xu
2008-04-30 5:37 ` David Miller
2008-11-20 11:59 ` SKB truesize bug Kostya B
2008-11-20 12:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).