From: Alexey Dobriyan <adobriyan@gmail.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: remove struct dst_ops::entry_size
Date: Tue, 11 Nov 2008 16:25:35 +0300 [thread overview]
Message-ID: <20081111132535.GB14810@x200.localdomain> (raw)
In-Reply-To: <20081111132445.GA14810@x200.localdomain>
On Tue, Nov 11, 2008 at 04:24:45PM +0300, Alexey Dobriyan wrote:
> Unused after kmem_cache_zalloc() conversion.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> include/net/dst.h | 1 -
> net/decnet/dn_route.c | 1 -
> net/ipv4/route.c | 2 --
> net/ipv4/xfrm4_policy.c | 1 -
> net/ipv6/route.c | 2 --
> net/ipv6/xfrm6_policy.c | 1 -
> 6 files changed, 8 deletions(-)
>
> --- a/include/net/dst.h
> +++ b/include/net/dst.h
> @@ -104,7 +104,6 @@ struct dst_ops
> void (*link_failure)(struct sk_buff *);
> void (*update_pmtu)(struct dst_entry *dst, u32 mtu);
> int (*local_out)(struct sk_buff *skb);
> - int entry_size;
>
> atomic_t entries;
> struct kmem_cache *kmem_cachep;
> --- a/net/decnet/dn_route.c
> +++ b/net/decnet/dn_route.c
> @@ -131,7 +131,6 @@ static struct dst_ops dn_dst_ops = {
> .negative_advice = dn_dst_negative_advice,
> .link_failure = dn_dst_link_failure,
> .update_pmtu = dn_dst_update_pmtu,
> - .entry_size = sizeof(struct dn_route),
> .entries = ATOMIC_INIT(0),
> };
>
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -160,7 +160,6 @@ static struct dst_ops ipv4_dst_ops = {
> .link_failure = ipv4_link_failure,
> .update_pmtu = ip_rt_update_pmtu,
> .local_out = __ip_local_out,
> - .entry_size = sizeof(struct rtable),
> .entries = ATOMIC_INIT(0),
> };
>
> @@ -2701,7 +2700,6 @@ static struct dst_ops ipv4_dst_blackhole_ops = {
> .destroy = ipv4_dst_destroy,
> .check = ipv4_dst_check,
> .update_pmtu = ipv4_rt_blackhole_update_pmtu,
> - .entry_size = sizeof(struct rtable),
> .entries = ATOMIC_INIT(0),
> };
>
> --- a/net/ipv4/xfrm4_policy.c
> +++ b/net/ipv4/xfrm4_policy.c
> @@ -248,7 +248,6 @@ static struct dst_ops xfrm4_dst_ops = {
> .ifdown = xfrm4_dst_ifdown,
> .local_out = __ip_local_out,
> .gc_thresh = 1024,
> - .entry_size = sizeof(struct xfrm_dst),
> .entries = ATOMIC_INIT(0),
> };
>
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -108,7 +108,6 @@ static struct dst_ops ip6_dst_ops_template = {
> .link_failure = ip6_link_failure,
> .update_pmtu = ip6_rt_update_pmtu,
> .local_out = __ip6_local_out,
> - .entry_size = sizeof(struct rt6_info),
> .entries = ATOMIC_INIT(0),
> };
>
> @@ -122,7 +121,6 @@ static struct dst_ops ip6_dst_blackhole_ops = {
> .destroy = ip6_dst_destroy,
> .check = ip6_dst_check,
> .update_pmtu = ip6_rt_blackhole_update_pmtu,
> - .entry_size = sizeof(struct rt6_info),
> .entries = ATOMIC_INIT(0),
> };
>
> --- a/net/ipv6/xfrm6_policy.c
> +++ b/net/ipv6/xfrm6_policy.c
> @@ -279,7 +279,6 @@ static struct dst_ops xfrm6_dst_ops = {
> .ifdown = xfrm6_dst_ifdown,
> .local_out = __ip6_local_out,
> .gc_thresh = 1024,
> - .entry_size = sizeof(struct xfrm_dst),
> .entries = ATOMIC_INIT(0),
> };
>
next prev parent reply other threads:[~2008-11-11 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-11 13:24 [PATCH] net: remove struct dst_entry::entry_size Alexey Dobriyan
2008-11-11 13:25 ` Alexey Dobriyan [this message]
2008-11-12 1:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081111132535.GB14810@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox