From: Evgeniy Polyakov <zbr@ioremap.net>
To: "Lovich, Vitali" <vlovich@qualcomm.com>
Cc: Johann Baudy <johaahn@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] Packet socket: mmapped IO: PACKET_TX_RING
Date: Tue, 11 Nov 2008 21:50:36 +0300 [thread overview]
Message-ID: <20081111185036.GA17717@ioremap.net> (raw)
In-Reply-To: <FCC0EC655BD1AE408C047268D1F5DF4C3BA611C3@NASANEXMB10.na.qualcomm.com>
Hi.
On Tue, Nov 11, 2008 at 10:14:54AM -0800, Lovich, Vitali (vlovich@qualcomm.com) wrote:
> Right, we're saying the exact same thing I think. I had wanted just a void * that is specific to PACKET_MMAP, so that no one else pays the price if they don't need to. You instead want to make it a feature flag - that's fine I think, but we need to make a note of that in the Kconfig file (that enabling PACKET_MMAP increases all skbs by the size of a long). I'd still rather prefer using the fragments instead though, because it seems like a reasonable solution that has 0 impact on any other code.
I think you should be almost 200% sure that skb is not allowed to grow up :)
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-11-11 18:50 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 10:58 [PATCH] Packet socket: mmapped IO: PACKET_TX_RING Johann Baudy
2008-10-31 17:07 ` Lovich, Vitali
2008-10-31 18:24 ` Lovich, Vitali
2008-11-04 22:45 ` Johann Baudy
2008-11-06 0:47 ` Lovich, Vitali
2008-11-06 8:03 ` Evgeniy Polyakov
2008-11-06 18:49 ` Lovich, Vitali
2008-11-06 19:40 ` Evgeniy Polyakov
2008-11-06 19:53 ` Lovich, Vitali
2008-11-07 16:36 ` Johann Baudy
2008-11-07 17:19 ` Lovich, Vitali
2008-11-10 20:29 ` Lovich, Vitali
2008-11-11 0:29 ` Lovich, Vitali
[not found] ` <7e0dd21a0811110656yff651afp8ff0f9928b79f545@mail.gmail.com>
2008-11-11 14:59 ` Johann Baudy
2008-11-11 19:05 ` Lovich, Vitali
2008-11-11 12:10 ` Johann Baudy
2008-11-11 17:44 ` Lovich, Vitali
2008-11-11 18:08 ` Johann Baudy
2008-11-11 18:19 ` Lovich, Vitali
2008-11-11 18:59 ` Johann Baudy
2008-11-11 19:10 ` Lovich, Vitali
2008-11-12 12:09 ` Johann Baudy
2008-11-12 17:12 ` Lovich, Vitali
2008-11-11 11:43 ` Johann Baudy
2008-11-11 17:38 ` Lovich, Vitali
2008-11-11 17:50 ` Johann Baudy
2008-11-11 18:14 ` Lovich, Vitali
2008-11-11 18:50 ` Evgeniy Polyakov [this message]
2008-11-11 19:19 ` Johann Baudy
2008-11-11 19:29 ` Evgeniy Polyakov
2008-11-12 13:43 ` Johann Baudy
2008-11-12 13:58 ` Evgeniy Polyakov
2008-11-12 17:07 ` Lovich, Vitali
2008-11-12 17:41 ` Evgeniy Polyakov
2008-11-12 17:59 ` Lovich, Vitali
2008-11-12 18:11 ` Evgeniy Polyakov
2008-11-12 19:05 ` Lovich, Vitali
2008-11-12 19:14 ` Evgeniy Polyakov
2008-11-12 21:23 ` Lovich, Vitali
2008-11-12 21:46 ` Evgeniy Polyakov
2008-11-12 22:33 ` Lovich, Vitali
2008-11-18 18:49 ` Johann Baudy
2008-11-18 19:10 ` Evgeniy Polyakov
2008-11-18 19:46 ` Lovich, Vitali
2008-11-07 17:28 ` Evgeniy Polyakov
2008-11-07 20:22 ` David Miller
2008-10-31 20:28 ` Evgeniy Polyakov
2008-11-04 22:33 ` Johann Baudy
2008-11-05 1:50 ` Lovich, Vitali
-- strict thread matches above, loose matches on Subject: below --
2008-11-12 13:19 Johann Baudy
2008-11-05 15:16 Johann Baudy
2008-11-05 17:49 ` Lovich, Vitali
2008-11-05 10:55 Johann Baudy
2008-11-05 11:02 ` Patrick McHardy
2008-11-05 17:32 ` Lovich, Vitali
2008-10-30 13:00 Johann Baudy
2008-10-30 18:21 ` Lovich, Vitali
2008-10-27 9:33 Johann Baudy
2008-10-28 22:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081111185036.GA17717@ioremap.net \
--to=zbr@ioremap.net \
--cc=johaahn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vlovich@qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).