netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Madore <david.madore@ens.fr>
To: "J. K. Cliburn" <jcliburn@gmail.com>
Cc: Linux Kernel Mailing-List <linux-kernel@vger.kernel.org>,
	Linux NetDev Mailing-List <netdev@vger.kernel.org>,
	atl1-devel@lists.sourceforge.net
Subject: Re: atl1e Ethernet driver not seeing packets sent to 33:33:00:00:00:01 multicast
Date: Tue, 11 Nov 2008 23:00:15 +0100	[thread overview]
Message-ID: <20081111220015.GA18215@clipper.ens.fr> (raw)
In-Reply-To: <20081111100816.58a7cf09@osprey.hogchain.net>

On Tue, Nov 11, 2008 at 10:08:16AM -0600, J. K. Cliburn wrote:
> Can you please try this patch?
> 
> diff --git a/drivers/net/atl1e/atl1e_hw.c b/drivers/net/atl1e/atl1e_hw.c
> index 949e753..c0d5f7c 100644
> --- a/drivers/net/atl1e/atl1e_hw.c
> +++ b/drivers/net/atl1e/atl1e_hw.c
> @@ -163,9 +163,6 @@ int atl1e_read_mac_addr(struct atl1e_hw *hw)
>   * atl1e_hash_mc_addr
>   *  purpose
>   *      set hash value for a multicast address
> - *      hash calcu processing :
> - *          1. calcu 32bit CRC for multicast address
> - *          2. reverse crc with MSB to LSB
>   */
>  u32 atl1e_hash_mc_addr(struct atl1e_hw *hw, u8 *mc_addr)
>  {
> @@ -174,7 +171,6 @@ u32 atl1e_hash_mc_addr(struct atl1e_hw *hw, u8 *mc_addr)
>  	int i;
>  
>  	crc32 = ether_crc_le(6, mc_addr);
> -	crc32 = ~crc32;
>  	for (i = 0; i < 32; i++)
>  		value |= (((crc32 >> i) & 1) << (31 - i));
>  

Now it works.  Many thanks!

Happy hacking,

-- 
     David A. Madore
    (david.madore@ens.fr,
     http://www.madore.org/~david/ )

  reply	other threads:[~2008-11-11 22:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11 13:31 atl1e Ethernet driver not seeing packets sent to 33:33:00:00:00:01 multicast David Madore
2008-11-11 14:06 ` J. K. Cliburn
2008-11-11 15:59   ` David Madore
2008-11-11 16:08     ` J. K. Cliburn
2008-11-11 22:00       ` David Madore [this message]
2008-11-12  0:13         ` J. K. Cliburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081111220015.GA18215@clipper.ens.fr \
    --to=david.madore@ens.fr \
    --cc=atl1-devel@lists.sourceforge.net \
    --cc=jcliburn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).