From: David Miller <davem@davemloft.net>
To: Doug.Leith@nuim.ie
Cc: netdev@vger.kernel.org, shemminger@vyatta.com
Subject: Re: [PATCH 2.6.27] tcp_htcp: last_cong bug fix
Date: Wed, 12 Nov 2008 01:44:03 -0800 (PST) [thread overview]
Message-ID: <20081112.014403.210407962.davem@davemloft.net> (raw)
In-Reply-To: <63599554-7243-4E44-BFEF-5B4B36743606@nuim.ie>
From: Douglas Leith <Doug.Leith@nuim.ie>
Date: Wed, 12 Nov 2008 08:58:18 +0000
> This patch fixes a minor bug in tcp_htcp.c which has been
> highlighted by Lachlan Andrew and Lawrence Stewart. Currently, the
> time since the last congestion event, which is stored in variable
> last_cong, is reset whenever there is a state change into
> TCP_CA_Open. This includes transitions of the type
> TCP_CA_Open->TCP_CA_Disorder->TCP_CA_Open which are not associated
> with backoff of cwnd. The patch changes last_cong to be updated
> only on transitions into TCP_CA_Open that occur after experiencing
> the congestion-related states TCP_CA_Loss, TCP_CA_Recovery,
> TCP_CA_CWR.
>
> Signed-off-by: Doug Leith <doug.leith@nuim.ie>
Applied, but I still had to fix up a bunch of details :-(
+ ca->undo_last_cong = 0;
That line had trailing whitespace.
+ case TCP_CA_Open:
That one too.
+ if (ca->undo_last_cong) {
That line had an initial set of space characters, instead
of pure leading tab characters.
+ ca->last_cong = jiffies;
More trailing whitespace.
+ break;
And some more trailing whitespace.
prev parent reply other threads:[~2008-11-12 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-09 19:09 [PATCH 2.6.27] tcp_htcp: last_cong bug fix Douglas Leith
2008-11-10 3:56 ` Lawrence Stewart
2008-11-10 10:07 ` Douglas Leith
2008-11-11 5:51 ` David Miller
2008-11-11 5:50 ` David Miller
2008-11-11 15:33 ` Douglas Leith
2008-11-11 22:16 ` David Miller
2008-11-12 8:36 ` Douglas Leith
2008-11-12 8:41 ` David Miller
2008-11-12 8:58 ` Douglas Leith
2008-11-12 9:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081112.014403.210407962.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Doug.Leith@nuim.ie \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).