From: David Miller <davem@davemloft.net>
To: adobriyan@gmail.com
Cc: dada1@cosmosbay.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3] net: #ifdef inet_bind_bucket::ib_net
Date: Thu, 13 Nov 2008 15:03:42 -0800 (PST) [thread overview]
Message-ID: <20081113.150342.26349899.davem@davemloft.net> (raw)
In-Reply-To: <b6fcc0a0811131453l4c111135p7b58453a533693ea@mail.gmail.com>
From: "Alexey Dobriyan" <adobriyan@gmail.com>
Date: Fri, 14 Nov 2008 01:53:26 +0300
> Something is wrong with read_pnet() as nobody suggested to mass use it
> or send a patch doing it.
>
> #ifdef CONFIG_NET_NS
> ib->ib_net = net;
> #endif
>
> It's _obvious_ from this code that it's a C assignment or nop. It's also
> obvious depending on what config option.
obvious, but ugly
> write_pnet(&ib->ib_net, net);
>
> What is & operator doing here? Is it important? '&' is syntaxic noise.
'&' is necessary for the assignment.
next prev parent reply other threads:[~2008-11-13 23:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 22:53 [PATCH v3] net: #ifdef inet_bind_bucket::ib_net Alexey Dobriyan
2008-11-13 23:03 ` David Miller [this message]
2008-11-13 23:09 ` Eric Dumazet
-- strict thread matches above, loose matches on Subject: below --
2008-11-13 23:21 Alexey Dobriyan
2008-11-14 4:36 ` Eric Dumazet
2008-11-14 4:40 ` David Miller
2008-11-14 4:54 ` Eric Dumazet
2008-11-14 6:14 ` Alexey Dobriyan
2008-11-14 6:21 ` Eric Dumazet
2008-11-14 6:41 ` Alexey Dobriyan
2008-11-11 0:44 [PATCH] net: introduce read_pnet() and write_pnet() functions David Miller
2008-11-11 11:08 ` [PATCH] net: #ifdef inet_bind_bucket::ib_net Alexey Dobriyan
2008-11-11 11:19 ` [PATCH v2] " Alexey Dobriyan
2008-11-12 0:45 ` David Miller
2008-11-12 10:44 ` Alexey Dobriyan
2008-11-12 10:50 ` Eric Dumazet
2008-11-12 12:24 ` [PATCH v3] " Alexey Dobriyan
2008-11-12 12:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113.150342.26349899.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=dada1@cosmosbay.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).