From: David Miller <davem@davemloft.net>
To: harvey.harrison@gmail.com
Cc: netdev@vger.kernel.org, kkeil@suse.de
Subject: Re: [PATCH] isdn: use %pI4, remove get_{u8/u16/u32} and put_{u8/u16/u32} inlines
Date: Thu, 13 Nov 2008 22:42:07 -0800 (PST) [thread overview]
Message-ID: <20081113.224207.25857066.davem@davemloft.net> (raw)
In-Reply-To: <1226639846.5483.3.camel@brick>
From: Harvey Harrison <harvey.harrison@gmail.com>
Date: Thu, 13 Nov 2008 21:17:25 -0800
> They would have been better named as get_be16, put_be16, etc.
> as they were hiding an endian shift inside.
>
> They don't add much over explicitly coding the byteshifting
> and gcc sometimes has a problem with builtin_constant_p inside
> inline functions, so it may do a better job of byteswapping
> at compile time rather than runtime.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Applied, thanks Harvey.
prev parent reply other threads:[~2008-11-14 6:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 5:17 [PATCH] isdn: use %pI4, remove get_{u8/u16/u32} and put_{u8/u16/u32} inlines Harvey Harrison
2008-11-14 6:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081113.224207.25857066.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=kkeil@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).