From: David Miller <davem@davemloft.net>
To: jdb@comx.dk
Cc: miltonm@bga.com, segher@kernel.crashing.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bhutchings@solarflare.com
Subject: Re: [PATCH] niu: bitwise or does not imply ordering
Date: Sun, 16 Nov 2008 12:49:24 -0800 (PST) [thread overview]
Message-ID: <20081116.124924.146154114.davem@davemloft.net> (raw)
In-Reply-To: <1226849525.8189.6.camel@localhost.localdomain>
From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Sun, 16 Nov 2008 16:32:05 +0100
>
> I have tested it on the actual hardware, it works...
>
> I actually agree that we should make it explicit, eventhough DaveM seems
> to disagree on the netdev list.
I'm also not applying this patch for another reason.
This is a knee-jerk reaction patch, purely. This person
saw the commit and wants to fix only _THIS_ case.
Well guess what? If you really CARED, you'd go change this
across the whole tree. This exact construct exists ALL
OVER the kernel. In fact there are sequences that match
this new NIU code exactly.
Did these people complaining look for those? No.
next prev parent reply other threads:[~2008-11-16 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <312268717986b8b45674.846930886.miltonm@bga.com>
2008-11-16 15:32 ` [PATCH] niu: bitwise or does not imply ordering Jesper Dangaard Brouer
2008-11-16 20:49 ` David Miller [this message]
2008-11-18 16:29 ` [SPARSE REQUEST] was " Milton Miller
2008-11-16 20:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081116.124924.146154114.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=jdb@comx.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
--cc=netdev@vger.kernel.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).