public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bazsi@balabit.hu
Cc: jengelh@medozas.de, tproxy@lists.balabit.hu,
	netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
	hidden@sch.bme.hu, andrey@icomsw.com
Subject: Re: [PATCH] [TPROXY] implemented IP_RECVORIGDSTADDR socket option
Date: Sun, 16 Nov 2008 19:32:10 -0800 (PST)	[thread overview]
Message-ID: <20081116.193210.05230282.davem@davemloft.net> (raw)
In-Reply-To: <1226572624.7164.11.camel@bzorp.balabit>

From: Balazs Scheidler <bazsi@balabit.hu>
Date: Thu, 13 Nov 2008 11:37:04 +0100

> In case UDP traffic is redirected to a local UDP socket,
> the originally addressed destination address/port
> cannot be recovered with the in-kernel tproxy.
> 
> This patch adds an IP_RECVORIGDSTADDR sockopt that enables
> a IP_ORIGDSTADDR ancillary message in recvmsg(). This
> ancillary message contains the original destination address/port
> of the packet being received.
> 
> Signed-off-by: Balazs Scheidler <bazsi@balabit.hu>

I'm going to apply this to net-next-2.6, thanks!

I was going to suggest simply adding a port member to the
in_pktinfo struct, because at worst the user will see
a MSG_CTRUNC.

But I guess that is not worth the risk.

If you want to do the function pointer cleanup suggested
by David Stevens, please make that as a followon patch.

Thanks.

      parent reply	other threads:[~2008-11-17  3:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 10:37 [PATCH] [TPROXY] implemented IP_RECVORIGDSTADDR socket option Balazs Scheidler
2008-11-13 11:09 ` Rémi Denis-Courmont
2008-11-13 11:37   ` Balazs Scheidler
2008-11-13 20:21 ` David Stevens
2008-11-14 12:41   ` Balazs Scheidler
2008-11-17  3:32 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081116.193210.05230282.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrey@icomsw.com \
    --cc=bazsi@balabit.hu \
    --cc=hidden@sch.bme.hu \
    --cc=jengelh@medozas.de \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=tproxy@lists.balabit.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox