From: David Miller <davem@davemloft.net>
To: dada1@cosmosbay.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: Cleanup of af_unix
Date: Sun, 16 Nov 2008 22:32:09 -0800 (PST) [thread overview]
Message-ID: <20081116.223209.239966240.davem@davemloft.net> (raw)
In-Reply-To: <49210AE7.3050405@cosmosbay.com>
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Mon, 17 Nov 2008 07:10:47 +0100
> @@ -1998,7 +1990,8 @@ static unsigned int unix_poll(struct file * file, struct socket *sock, poll_tabl
> mask |= POLLIN | POLLRDNORM;
>
> /* Connection-based need to check for termination and startup */
> - if ((sk->sk_type == SOCK_STREAM || sk->sk_type == SOCK_SEQPACKET) && sk->sk_state == TCP_CLOSE)
> + if ((sk->sk_type == SOCK_STREAM || sk->sk_type == SOCK_SEQPACKET) &&
> + sk->sk_state == TCP_CLOSE)
> mask |= POLLHUP;
>
> /*
This should instead be:
if ((sk->sk_type == SOCK_STREAM || sk->sk_type == SOCK_SEQPACKET) &&
sk->sk_state == TCP_CLOSE)
> Some long lines (over 80 columns) were not changed, please tell me if you prefer
> them go.
I'm ambivalent, at which point it's just noise and merge hassles, so let's
just leave it alone.
next prev parent reply other threads:[~2008-11-17 6:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 6:10 [PATCH] net: Cleanup of af_unix Eric Dumazet
2008-11-17 6:32 ` David Miller [this message]
2008-11-17 6:46 ` Eric Dumazet
2008-11-17 6:59 ` David Miller
2008-11-17 7:34 ` Joe Perches
2008-11-17 7:48 ` Eric Dumazet
2008-11-17 19:20 ` Eric Dumazet
2008-11-19 23:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081116.223209.239966240.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dada1@cosmosbay.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).