From: David Miller <davem@davemloft.net>
To: wangchen@cn.fujitsu.com
Cc: jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2]netdevice: 82596: Convert netdev->priv to netdev_priv
Date: Mon, 17 Nov 2008 01:29:39 -0800 (PST) [thread overview]
Message-ID: <20081117.012939.72047312.davem@davemloft.net> (raw)
In-Reply-To: <49213856.6040802@cn.fujitsu.com>
From: Wang Chen <wangchen@cn.fujitsu.com>
Date: Mon, 17 Nov 2008 17:24:38 +0800
> The memory, which pointed by netdev->priv, can be allocated by alloc_etherdev().
> We don't need to use __get_free_pages() to get memory.
>
> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
I don't think this is right either.
There might be device imposed alignment constraints, for example.
And a whole page is also being allocated so that this cache mode
change doesn't have an effect on unrelated kernel memory. That could
kill performance if some critical other data structure sits in the
same page and now has it's cacheability disabled.
next prev parent reply other threads:[~2008-11-17 9:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 6:04 [PATCH net-next]netdevice: 82596: Convert netdev->priv to netdev_priv Wang Chen
2008-11-17 6:36 ` David Miller
2008-11-17 6:58 ` Wang Chen
2008-11-17 9:24 ` [PATCH net-next v2]netdevice: " Wang Chen
2008-11-17 9:29 ` David Miller [this message]
2008-11-17 14:42 ` Wang Chen
2008-11-18 3:57 ` [PATCH net-next v3]netdevice: " Wang Chen
2008-11-20 9:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081117.012939.72047312.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).